Seqkit replace - fix #9647 and #9646#9686
Open
ammaraziz wants to merge 2 commits intonf-core:masterfrom
Open
Conversation
SPPearce
reviewed
Jan 19, 2026
Contributor
SPPearce
left a comment
There was a problem hiding this comment.
We normally catch cases where the input file can be the same as the output file in this way:
https://github.com/search?q=repo%3Anf-core%2Fmodules%20disambig&type=code
Which can be combined with setting a default value for prefix that isn't just meta.id, e.g.
def prefix = task.ext.prefix ?: "${meta.id}_replaced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #9647 and #9646
-iflag incorrectly used as input,-ifor ignoring case.