Skip to content

WIP: Add sanitizeOutputs to all modules/subworkflows - #12820

Draft
matthdsm wants to merge 2 commits into
masterfrom
sanitation-crew
Draft

WIP: Add sanitizeOutputs to all modules/subworkflows#12820
matthdsm wants to merge 2 commits into
masterfrom
sanitation-crew

Conversation

@matthdsm

Copy link
Copy Markdown
Contributor

Add sanitizeOutputs to module tests where missing

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@SPPearce

Copy link
Copy Markdown
Contributor

@matthdsm , what are you doing? There is no way we can get this through the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants