add seq_type to anarcii module - #12813
Open
mapo9 wants to merge 4 commits into
Open
Conversation
mapo9
marked this pull request as draft
August 26, 2026 09:59
mapo9
marked this pull request as ready for review
August 26, 2026 10:06
ANARCII's Score column drifts with thread count, so a whole-file md5 is not portable across machines and failed in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/modules pull request
PR checklist
Adds
seq_typeas an input toanarcii, passed to the tool's-tflag.-t/--seq_typedefaults toantibody. The module never sets it, so numbering other input needs anext.argsoverride that is easy to omit, and getting it wrong is silent: ANARCII returns unnumbered chainFinstead of erroring.That's why I consider that the flag should be part of the nf-core modules. Also, AFAIK no pipeline uses it yet (mine will very soon :D), so PR won't break anything
labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda