Update to topic qualimap - #12625
Conversation
| def strandedness = 'non-strand-specific' | ||
| if (meta.strandedness == 'forward') { | ||
| strandedness = 'strand-specific-forward' | ||
| } else if (meta.strandedness == 'reverse') { | ||
| strandedness = 'strand-specific-reverse' | ||
| } |
There was a problem hiding this comment.
I don't really like breaking the existing code like this, by just ignoring the strandedness entirely.
There was a problem hiding this comment.
My reasoning is that it is an optional argument for these tools (non-strand-specific as default).
As such, shouldn't it be passed through ext.args ?
There was a problem hiding this comment.
Yeah, in theory ;)
Personally I think meta.strandedness should still be allowed
There was a problem hiding this comment.
Okay, I will put it back then !
There was a problem hiding this comment.
Well, it isn't allowed by the linter at the moment
There was a problem hiding this comment.
Yeah, now I remember why I deleted it 😕
What's the recommended course of action ?
Should we move it to a separate value channel ?
2 participants
PR checklist
Closes #12622
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda