Add rclone check and checksum#12269
Open
atrigila wants to merge 6 commits into
Open
Conversation
SPPearce
reviewed
Jul 8, 2026
| then { | ||
| assertAll( | ||
| { assert process.success }, | ||
| { assert snapshot([match: process.out.match, versions_rclone: process.out.versions_rclone]).match() } |
Contributor
There was a problem hiding this comment.
why not sanitizeOutput(process.out)?
Contributor
Author
There was a problem hiding this comment.
I should have clarified this in the PR description. I tried that. If you snapshot all results it will produce empty files for the optional output processes (and that would make the linter fail). This is the "cleanest" I could come up with but I am open to hear if you have any other suggestion.
Contributor
There was a problem hiding this comment.
sanitizeOutput(process.out, unstableKeys: ["combined", "differ", "missing_on_dst", "missing_on_src","error"]) ?
SPPearce
reviewed
Jul 8, 2026
SPPearce
reviewed
Jul 8, 2026
SPPearce
left a comment
SPPearce
left a comment
Contributor
There was a problem hiding this comment.
Why are you doing something unusual in the snapshots?
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Contributor
Author
|
@SPPearce Do you have any other idea on how to approach this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created two new modules for the
RCLONEsuite:rclone checkandrclone checksum. I used the new functionality in nf-core/tools (dev) to create the container forrclone(which includes conda-lock files) fromenvironment.ymlfiles.Notes:
|| true, so it won't fail, but we will get the files with the report.Related to: nf-core/datasync#44