Skip to content

add new module: aardvark/compare#12260

Merged
kubranarci merged 12 commits into
nf-core:masterfrom
kubranarci:12172-new-module-aardvark
Jul 8, 2026
Merged

add new module: aardvark/compare#12260
kubranarci merged 12 commits into
nf-core:masterfrom
kubranarci:12172-new-module-aardvark

Conversation

@kubranarci

@kubranarci kubranarci commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@kubranarci kubranarci requested a review from georgiakes July 7, 2026 11:22
@kubranarci kubranarci self-assigned this Jul 7, 2026
Comment thread modules/nf-core/aardvark/compare/main.nf
Comment thread modules/nf-core/aardvark/compare/main.nf Outdated
kubranarci and others added 3 commits July 7, 2026 16:28
Co-authored-by: Georgia Kesisoglou <georgiakes@gmail.com>
Co-authored-by: Georgia Kesisoglou <georgiakes@gmail.com>
Comment thread modules/nf-core/aardvark/compare/main.nf Outdated
@kubranarci

Copy link
Copy Markdown
Contributor Author

@georgiakes do you have more comments :D

@georgiakes

Copy link
Copy Markdown
Member

I think that's it🫣

@kubranarci

Copy link
Copy Markdown
Contributor Author

I think that's it🫣

Can I have an approve :D

@georgiakes

Copy link
Copy Markdown
Member

Oh sorry for I thought you have seen those
image

@kubranarci

kubranarci commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

did you push your commends? I think they are pending

Comment thread modules/nf-core/aardvark/compare/main.nf
@@ -0,0 +1,63 @@
process AARDVARK_COMPARE {
tag "$meta.id"
label 'process_single'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the tools allows multi threading, should we use another label?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think single is still good, maybe also low. but not medium.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure low. The only reason I'm saying it is because with single the task.cpu becomes useless.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to low now

Comment thread modules/nf-core/aardvark/compare/tests/main.nf.test Outdated
Comment thread modules/nf-core/aardvark/compare/meta.yml Outdated
Comment thread modules/nf-core/aardvark/compare/meta.yml Outdated
Comment thread modules/nf-core/aardvark/compare/tests/main.nf.test Outdated
kubranarci and others added 5 commits July 8, 2026 10:40
Co-authored-by: Georgia Kesisoglou <georgiakes@gmail.com>
Co-authored-by: Georgia Kesisoglou <georgiakes@gmail.com>
Co-authored-by: Georgia Kesisoglou <georgiakes@gmail.com>
@kubranarci

Copy link
Copy Markdown
Contributor Author

thank youuu @georgiakes

@kubranarci kubranarci added this pull request to the merge queue Jul 8, 2026
Merged via the queue into nf-core:master with commit 5b47f16 Jul 8, 2026
15 checks passed
@kubranarci kubranarci deleted the 12172-new-module-aardvark branch July 8, 2026 09:19
@georgiakes georgiakes mentioned this pull request Jul 8, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants