Skip to content

Update to topic metamaps/*#12246

Open
LouisLeNezet wants to merge 4 commits into
nf-core:masterfrom
LouisLeNezet:metamaps
Open

Update to topic metamaps/*#12246
LouisLeNezet wants to merge 4 commits into
nf-core:masterfrom
LouisLeNezet:metamaps

Conversation

@LouisLeNezet

Copy link
Copy Markdown
Contributor

PR checklist

Closes #12078
Closes #12079

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this Jul 6, 2026

@itrujnara itrujnara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itrujnara

Copy link
Copy Markdown
Contributor

@nf-core-bot fix linting

@nf-core-bot nf-core-bot requested review from a team, edmundmiller and maxulysse as code owners July 6, 2026 12:13
@LouisLeNezet

Copy link
Copy Markdown
Contributor Author

@itrujnara it seems that the nf-core bot failed to lint only the modified files.
It added many changes 😅

@mashehu

mashehu commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

yes, the bot runs prek with --all-files, fixed in #12221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to topic metamaps/mapdirectly Migrate to topic metamaps/classify

4 participants