Added nf-core module presto/pairseq#12222
Open
Vivian0105 wants to merge 3 commits into
Open
Conversation
mashehu
requested changes
Jul 3, 2026
| val(barcode_position) | ||
|
|
||
| output: | ||
| tuple val(meta), path("*_pair-pass.fastq.gz"), path("*_pair-pass.fastq.gz") , emit: reads |
Contributor
There was a problem hiding this comment.
will using the same glob not resulting in both channels having both reads? Can't you somehow distinguish between read 1 and read 2 in the output to preserve the order?
Comment on lines
+29
to
+39
| assertAll( | ||
| { assert process.success}, | ||
| { assert snapshot( | ||
| process.out.reads.get(0).get(1), | ||
| process.out.reads.get(0).get(2) | ||
| ).match("test_snap_out")}, | ||
| { assert snapshot( | ||
| process.out.versions_presto).match("test_snap_versions") | ||
| }, | ||
| { assert path(process.out.logs.get(0)).getText().contains("PASS") } | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| assertAll( | |
| { assert process.success}, | |
| { assert snapshot( | |
| process.out.reads.get(0).get(1), | |
| process.out.reads.get(0).get(2) | |
| ).match("test_snap_out")}, | |
| { assert snapshot( | |
| process.out.versions_presto).match("test_snap_versions") | |
| }, | |
| { assert path(process.out.logs.get(0)).getText().contains("PASS") } | |
| ) | |
| assert process.success | |
| assertAll( | |
| { assert snapshot( | |
| process.out.reads, | |
| process.out.findAll { key, val -> key.startsWith("versions") } | |
| ).match() }, | |
| { assert path(process.out.logs.get(0)).getText().contains("PASS") } | |
| ) |
a bit more compact way to write this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open issue: #12206
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda