Skip to content

Bump delly call#11080

Open
bagnacan wants to merge 3 commits intonf-core:masterfrom
bagnacan:bump-delly-call
Open

Bump delly call#11080
bagnacan wants to merge 3 commits intonf-core:masterfrom
bagnacan:bump-delly-call

Conversation

@bagnacan
Copy link
Copy Markdown
Contributor

This PR bumps the version of delly call from 1.3.3 to 1.7.3 and makes use of its thread command line option.

PR checklist

  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@bagnacan
Copy link
Copy Markdown
Contributor Author

bagnacan commented Mar 29, 2026

@nvnieuwk, I'm obtaining linting errors that I cannot reproduce when I lint the module locally. What am I missing?

@bagnacan bagnacan force-pushed the bump-delly-call branch 2 times, most recently from f44f67e to 96e5366 Compare March 30, 2026 07:23
script:
def args = task.ext.args ?: ''
def args2 = task.ext.args2 ?: ''
def args3 = task.ext.args3 ?: "bcf"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

args* are only used for general command-line arguments.

The replacement for ext.suffix is making an extra field in one of existing input channels, or making a new input channel.
See the wget module for an example.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Matthieu! I will change it accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants