Skip to content

Update merqury build number (addresses a bug)#11070

Merged
CormacKinsella merged 4 commits intonf-core:masterfrom
CormacKinsella:patch_merqury
Mar 31, 2026
Merged

Update merqury build number (addresses a bug)#11070
CormacKinsella merged 4 commits intonf-core:masterfrom
CormacKinsella:patch_merqury

Conversation

@CormacKinsella
Copy link
Copy Markdown
Contributor

PR checklist

  • Updated the merqury build number for the conda env, + both the docker & singularity biocontainers. The reason is the underlying meryl dependency was out of date (version 1.3), and led to empty qv files. Meryl has been updated to v1.4.1 in the latest build of merqury 1.3, see: update merqury: bump meryl dependency to 1.4.1 bioconda/bioconda-recipes#61223

  • Added version reporting for the meryl dependency

  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:

    • For modules:
      • nf-core modules test <MODULE> --profile singularity:
│ Test Process MERQURY_MERQURY                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           │
│   Test [c6850a47] 'homo_sapiens-genome' PASSED (64.1s)                                                                                                                                                                                                                                                              │
│   Test [a187d5b9] 'homo_sapiens-genome-trio' PASSED (115.277s)                                                                                                                                                                                                                                                      │
│   Test [fafd5765] 'homo_sapiens-genome-stub' PASSED (10.925s)                                                                                                                                                                                                                                                       │                                                                                                                                                                                                                                                                                          │
│ SUCCESS: Executed 3 tests in 191.16s

@famosab
Copy link
Copy Markdown
Contributor

famosab commented Mar 31, 2026

Please join the nf-core org via the slack #github-invitations so that the CI tests are running for yoiu :)

@CormacKinsella
Copy link
Copy Markdown
Contributor Author

@famosab thanks for the tip, have requested now

@CormacKinsella CormacKinsella added this pull request to the merge queue Mar 31, 2026
Merged via the queue into nf-core:master with commit b4efa75 Mar 31, 2026
21 checks passed
@CormacKinsella CormacKinsella deleted the patch_merqury branch March 31, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants