Open
Conversation
Contributor
|
Please join the nf-core organization on GitHub to enable the CI-tests to run on your PR. You can request to join the organization via #github-invitations in the nf-core slack. You can join the nf-core slack via https://nf-co.re/join. |
famosab
reviewed
Apr 2, 2026
Contributor
famosab
left a comment
famosab
left a comment
There was a problem hiding this comment.
Thank you for your contribution to nf-core! We really appreciate it. I added a few comments to your PR.
| } | ||
|
|
||
| then { | ||
| assert workflow.success |
Contributor
There was a problem hiding this comment.
We also want a snapshot here (look at other subworkflows)
| missing | ||
|
|
||
| main: | ||
| versions = Channel.empty() |
Contributor
There was a problem hiding this comment.
Check for each module if they still export the versions I think at least bcftools/filter does not anymore
| - vcf: | ||
| type: file | ||
| description: "Multi-sample VCF file (bgzipped and indexed)" | ||
| pattern: "*.{vcf,vcf.gz}" |
Contributor
There was a problem hiding this comment.
Suggested change
| pattern: "*.{vcf,vcf.gz}" | |
| pattern: "*.vcf.gz" |
| FLASHPCA2 ( PLINK2_RECODE_VCF.out.vcf ) | ||
| versions = versions.mix(FLASHPCA2.out.versions.first()) | ||
|
|
||
| // TODO: qui aggiungeremo KMeans/DBSCAN/plot quando creeremo i moduli local |
Contributor
There was a problem hiding this comment.
Is there still something to add?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
snpclusteringsubworkflow for end-to-end unsupervised clustering of genomic samples directly from multi-sample VCF files.Features
bcftools/filterplink2/indeppairwiseplink2/recodevcfflashpca2The subworkflow was developed in relation to the accepted nf-core proposal for the
consepopgenpipeline.Related to:
Checklist
nf-core subworkflows lint snpclusteringpassednf-core subworkflows test snpclusteringpassedCloses # (no specific issue)