Repository navigation
fix(cron): do not abort cleanup job when attachments cannot be deleted - #9514
Merged
Merged
Conversation
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-opus-5.5
max-nextcloud
approved these changes
Nov 3, 2026
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks!
Collaborator
Author
|
CI failure is unrelated |
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
The log is flooded by this error:
The cleanup job runs every 5 minutes and can't remove unreferenced/unused attachments in folders without delete permission. The exception isn't caught, so the job aborts, logs the error and skips the rest of its cleanup work. And because the document stays on the job's list, the job tries it again on every run and fails the same way each time.
Log a warning instead and mark the document, so it is only retried after it has been saved again.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI