Repository navigation
[stable33] fix(cron): stop attachment cleanup from failing on every run - #9517
Open
silverkszlo wants to merge 1 commit into
Open
silverkszlo wants to merge 1 commit into
silverkszlo wants to merge 1 commit into
Conversation
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-opus-5.5
mejo-
approved these changes
Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
The bug
The cleanup job resets documents without an active session before it cleans up their attachments. Documents with unsaved changes are not reset and stay in the table, but their attachments were still cleaned up. As a result, these documents are processed again on every run. If deleting an unused attachment is not permitted (e.g. a team folder without delete permission or a read-only storage), the
NotPermittedExceptionaborted the job every 5 minutes and skipped the remaining cleanup steps.The fix
Skip documents with unsaved changes, as the saved file may not yet reference attachments that are only used in unsaved steps. For saved documents, log a warning instead of aborting the job.
Unlike main, stable33 does not need the
last_attachment_cleanupcolumn from #9166, because the reset already removes processed documents.On main this is fixed by #9166 and #9514. For stable35 and stable34, #9166 is backported together with the fix from #9514 (#9515, #9516).
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI