Repository navigation
fix(db): filter conversion tables by configured prefix - #56174
Open
joshtrichards wants to merge 1 commit into
Open
joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
joshtrichards
added
bug
3. to review
joshtrichards
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
yemkareems
and removed request for
a team
November 3, 2025 23:28
Merged
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
Merged
Closed
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/db-convert-copytable-filter
branch
from
October 17, 2026 14:59
9ff5072 to
8351fe5
Compare
2 of 7 tasks
joshtrichards
changed the title
nickvergessen
approved these changes
Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During conversion, the table filter could include tables that don’t start with the configured prefix. This could cause unrelated tables to be included in the conversion or removed when using
--clear-schema.preg_match()returns1for a match,0for no match, andfalseon error. The previous!== falsecheck accepted0as well as1. Checking for=== 1ensures only actual Nextcloud tables are included.P.S. Exact same matter in
gSqlTools::resynchronizeDatabaseSequences(), which runs later if the target is PostgreSQL, is dealt with in PR #56173.TODO
Follow-up matters
ConvertTypecurrently lacks test coverage; should be dealt with in a follow-up PRChecklist
3. to review, feature component)stable32)