Repository navigation
fix(db): exclude schema assets without the configured table prefix - #56173
Open
joshtrichards wants to merge 1 commit into
Open
joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
joshtrichards
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
November 3, 2025 23:15
joshtrichards
requested review from
CarlSchwan,
leftybournes and
nickvergessen
November 3, 2025 23:15
2 of 7 tasks
Merged
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
Merged
Closed
The schema assets filter previously used preg_match(... ) !== false, which treats 0 (no match) as true and caused non-matching assets to be accepted. Use preg_match(... ) === 1 so the filter only accepts actual matches and avoids false positives. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/db-pgsql-seq-filter
branch
from
October 17, 2026 15:00
8acbe3e to
f880dfb
Compare
joshtrichards
changed the title
nickvergessen
approved these changes
Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During conversion to PostgreSQL, the sequence filter could include sequences that don’t match the configured table prefix, causing unrelated sequences to be considered during resynchronization.
preg_match()returns1for a match,0for no match, andfalseon error. The previous!== falsecheck accepted0as well as1. Checking for=== 1ensures only actual prefix matches are included.P.S. Exact same matter in
ConvertType::getTables()itself, which runs before this and and for other database types, is dealt with in PR #56174.TODO
Follow-up matters
PgSqlToolscurrent lacks test coverage; should be dealt with in a follow-up PRChecklist
3. to review, feature component)stable32)