fix: connectivity service

[alperozturk96]

• Tests written, or not not needed

Fixes: #14681

Deduplicates isNetworkAndServerAvailable logic

Implements ConnectivityManager.NetworkCallback for better network state listening

Removes deprecated logics

Adds better documentation

Adds exception handling for http call to prevent temporary issues thus we don't inform user with incorrect availability state

Uses for metered detection NET_CAPABILITY_NOT_METERED instead of NET_CAPABILITY_NOT_RESTRICTED

Removes network change receiver uses listener for much better reaction to network change

Converts to Kotlin

[TheCrowned]

I gave this build a try - same error for me (both on upload, and on file listing).
The screenshot clearly shows network is available, both as WiFi and as data.
If it can help troubleshooting, upload works when I turn off WiFi and only leave data.

[alperozturk96]

@TheCrowned Hello. Thank you for the feedback. I updated the PR. Could you please check via latest APK file once its generated?

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/24078742104/artifacts/6304625309
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/24130016101/artifacts/6325219637
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/24130503589/artifacts/6325539905
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[TheCrowned]

@alperozturk96 I see you're still actively working on this. Should I try the new build already, or let things settle longer? Thanks for your work.

[alperozturk96]

@alperozturk96 I see you're still actively working on this. Should I try the new build already, or let things settle longer? Thanks for your work.

Hey, you can try last generated apk like this, and share your feedback:

---

Thank you so much, it helps a lot 💯

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[TheCrowned]

Still no, I'm sorry. WiFi is on, data is off (and in that condition I'm writing this message), and the app reports no connectivity when trying to uplaod files via the Share button in gallery. Also, the app allows to navigate through nextcloud directories and doesn't say "no connectivity", but shows all dirs I had not previously opened as empty.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/24140818844/artifacts/6330035040
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	36	36
Correctness	69	69
Dodgy code	228	227
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	42	42
Security	16	16
Total	435	434

[github-actions]

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16232-Unit-test-14-48