Skip to content

Conversation

@RoDmitry
Copy link
Contributor

@RoDmitry RoDmitry commented Aug 1, 2025

No description provided.

@ssrlive
Copy link
Collaborator

ssrlive commented Oct 10, 2025

Hi @SajjadPourali , do you think we should merge this PR?

@ssrlive ssrlive requested a review from Copilot October 10, 2025 02:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the internal task handle for the IpStack to allow external callers to abort the background task when needed. The change makes the previously private _handle field publicly accessible as handle and updates the associated comment to clarify its purpose.

  • Changed private _handle field to public handle field in IpStack struct
  • Updated comment to document the field's purpose for aborting on disconnect

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ssrlive ssrlive changed the title IpStack pub handle for aborting on disconnect IpStack pub abort method for aborting on disconnect Oct 10, 2025
@ssrlive ssrlive requested a review from Copilot October 10, 2025 02:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SajjadPourali
Copy link
Collaborator

Hi @SajjadPourali , do you think we should merge this PR?

Negative, we can abort it in Drop.

@ssrlive
Copy link
Collaborator

ssrlive commented Oct 10, 2025

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants