-
Notifications
You must be signed in to change notification settings - Fork 20
IpStack pub abort method for aborting on disconnect
#63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @SajjadPourali , do you think we should merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR exposes the internal task handle for the IpStack to allow external callers to abort the background task when needed. The change makes the previously private _handle field publicly accessible as handle and updates the associated comment to clarify its purpose.
- Changed private
_handlefield to publichandlefield in IpStack struct - Updated comment to document the field's purpose for aborting on disconnect
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pub handle for aborting on disconnectpub abort method for aborting on disconnect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Negative, we can abort it in |
|
OK |
No description provided.