Skip to content

Conversation

@SajjadPourali
Copy link
Collaborator

@SajjadPourali SajjadPourali commented Oct 10, 2025

#63

@SajjadPourali SajjadPourali requested a review from Copilot October 10, 2025 03:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the IpStack struct to properly handle task cleanup by exposing the task handle and implementing a Drop trait to abort the background task when the IpStack instance is dropped.

  • Renamed the private _handle field to public handle to allow external access
  • Implemented Drop trait to automatically abort the background task on cleanup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SajjadPourali SajjadPourali requested a review from Copilot October 10, 2025 04:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SajjadPourali SajjadPourali self-assigned this Oct 10, 2025
@RoDmitry
Copy link
Contributor

Ok, even better. Remove or change // Just hold the task handle comment

@SajjadPourali SajjadPourali requested a review from Copilot October 10, 2025 15:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SajjadPourali SajjadPourali merged commit f7f96e1 into main Oct 10, 2025
4 checks passed
@SajjadPourali SajjadPourali deleted the DropIpstackHandle branch October 10, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants