Skip to content

Mark test_logging as requiring a web connection #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badboy merged 1 commit into from
Oct 22, 2026
Merged

Mark test_logging as requiring a web connection #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Fix tests that failed when `SOURCE_DATE_EPOCH` is set in the environment
- Add a `skip_schema_validation` option to `parse_objects` to skip schema validation of input files ([bug 2076540](https://bugzilla.mozilla.org/show_bug.cgi?id=2076540))
- Mark `test_logging` as requiring a web connection

## 22.0.1

Expand Down
2 changes: 2 additions & 0 deletions tests/test_python_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import subprocess
import sys

import pytest

from glean_parser import translate
from glean_parser import validate_ping
Expand All @@ -31,6 +32,7 @@ def test_no_event_metrics(tmp_path):
assert all(False for _ in tmp_path.iterdir())


@pytest.mark.web_dependency
def test_logging(tmp_path):
"""Test that generated code can be used to log events in the right format."""

Expand Down
Loading