Skip to content

Mark test_logging as requiring a web connection - #873

Merged
badboy merged 1 commit into
mozilla:mainfrom
andersk:test_logging
Oct 22, 2026
Merged

badboy merged 1 commit into
mozilla:mainfrom
andersk:test_logging

Conversation

@andersk

@andersk andersk commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

This test uses validate_ping() to fetch glean.1.schema.json from GitHub, so it needs a web connection.

schema_url = (
"https://raw.githubusercontent.com/mozilla-services/"
"mozilla-pipeline-schemas/main/"
"schemas/glean/glean/glean.1.schema.json"
)
# validate that ping payload is valid against glean schema
input = io.StringIO(payload)
output = io.StringIO()
assert validate_ping.validate_ping(input, output, schema_url=schema_url) == 0, (
output.getvalue()
)

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@andersk
andersk requested review from a team and akkomar as code owners October 20, 2026 22:50
@andersk
andersk requested review from jeddai and removed request for a team October 20, 2026 22:50
This test uses `validate_ping()` to fetch `glean.1.schema.json` from
GitHub, so it needs a web connection.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@badboy
badboy enabled auto-merge (rebase) October 22, 2026 09:37
@badboy
badboy merged commit 65bd1d1 into mozilla:main Oct 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants