Skip to content

fix(sequentialthinking): correct readOnlyHint and idempotentHint annotations #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somuai wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

fix(sequentialthinking): correct readOnlyHint and idempotentHint annotations #4747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/sequentialthinking/__tests__/input-schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@ describe.skipIf(!existsSync(distIndexPath))('sequentialthinking input schema', (
await client?.close();
});

it('advertises accurate annotations (stateful and non-idempotent)', async () => {
const { tools } = await client.listTools();
const tool = tools.find(t => t.name === 'sequentialthinking');
expect(tool).toBeDefined();
expect(tool!.annotations).toEqual({
readOnlyHint: false,
destructiveHint: false,
idempotentHint: false,
openWorldHint: false,
});
});

it('advertises nextThoughtNeeded as required', async () => {
const { tools } = await client.listTools();
const tool = tools.find(t => t.name === 'sequentialthinking');
Expand Down
4 changes: 2 additions & 2 deletions src/sequentialthinking/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ You should:
needsMoreThoughts: coercedBoolean.optional().describe("If more thoughts are needed")
},
annotations: {
readOnlyHint: true,
readOnlyHint: false,
destructiveHint: false,
idempotentHint: true,
idempotentHint: false,
openWorldHint: false,
},
outputSchema: {
Expand Down