fix(sequentialthinking): correct readOnlyHint and idempotentHint annotations - #4747
Open
somuai wants to merge 1 commit into
Open
fix(sequentialthinking): correct readOnlyHint and idempotentHint annotations#4747somuai wants to merge 1 commit into
somuai wants to merge 1 commit into
Conversation
… annotations - Set readOnlyHint: false because the server maintains per-session thoughtHistory and branches state - Set idempotentHint: false because sequential calls produce different history lengths - Add regression assertion in input-schema.test.ts - Fixes modelcontextprotocol#4721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4721.
Problem
The
sequentialthinkingtool annotations previously specifiedreadOnlyHint: trueandidempotentHint: true. However:thoughtHistoryandbranches), which mutates on everyprocessThoughtinvocation. It is therefore stateful, not read-only.thoughtHistoryLengthvalues (and mutate branches), making the tool non-idempotent by definition. Clients relying onreadOnlyHint(e.g. for parallel execution safety) oridempotentHint(e.g. for caching or automatic retries) would encounter unexpected side effects.Solution
readOnlyHint: falseandidempotentHint: falseinsrc/sequentialthinking/index.ts.src/sequentialthinking/__tests__/input-schema.test.tsverifying that advertised tool annotations accurately reflect statefulness.