Skip to content

fix(docker): switch to non-root user in container images #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teddiesloco wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

fix(docker): switch to non-root user in container images #4745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/fetch/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ RUN --mount=type=cache,target=/root/.cache/uv \

FROM python:3.12-slim-bookworm

RUN if ! id -u app >/dev/null 2>&1; then useradd -rUM -s /usr/sbin/nologin app; fi

WORKDIR /app

COPY --from=uv /root/.local /root/.local
Expand All @@ -32,6 +34,8 @@ RUN if ! id -u app >/dev/null 2>&1; then \
fi
COPY --from=uv --chown=app:app /app/.venv /app/.venv

USER app

# Place executables in the environment at the front of the path
ENV PATH="/app/.venv/bin:$PATH"

Expand Down
2 changes: 2 additions & 0 deletions src/filesystem/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,6 @@ ENV NODE_ENV=production

RUN npm ci --ignore-scripts --omit-dev

USER node

ENTRYPOINT ["node", "/app/dist/index.js"]
4 changes: 4 additions & 0 deletions src/git/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ FROM python:3.12-slim-bookworm
RUN apt-get update && apt-get install -y git git-lfs && rm -rf /var/lib/apt/lists/* \
&& git lfs install --system

RUN if ! id -u app >/dev/null 2>&1; then useradd -rUM -s /usr/sbin/nologin app; fi

WORKDIR /app

COPY --from=uv /root/.local /root/.local
Expand All @@ -35,6 +37,8 @@ RUN if ! id -u app >/dev/null 2>&1; then \
fi
COPY --from=uv --chown=app:app /app/.venv /app/.venv

USER app

# Place executables in the environment at the front of the path
ENV PATH="/app/.venv/bin:$PATH"

Expand Down
2 changes: 2 additions & 0 deletions src/memory/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,6 @@ WORKDIR /app

RUN npm ci --ignore-scripts --omit-dev

USER node

ENTRYPOINT ["node", "dist/index.js"]
4 changes: 4 additions & 0 deletions src/time/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ RUN --mount=type=cache,target=/root/.cache/uv \

FROM python:3.12-slim-bookworm

RUN if ! id -u app >/dev/null 2>&1; then useradd -rUM -s /usr/sbin/nologin app; fi

WORKDIR /app

COPY --from=uv /root/.local /root/.local
Expand All @@ -32,6 +34,8 @@ RUN if ! id -u app >/dev/null 2>&1; then \
fi
COPY --from=uv --chown=app:app /app/.venv /app/.venv

USER app

# Place executables in the environment at the front of the path
ENV PATH="/app/.venv/bin:$PATH"

Expand Down