fix(docker): switch to non-root user in container images - #4745
Open
teddiesloco wants to merge 1 commit into
Open
fix(docker): switch to non-root user in container images#4745teddiesloco wants to merge 1 commit into
teddiesloco wants to merge 1 commit into
Conversation
…ainer images Closes modelcontextprotocol#4741. Switched fetch, git, and time images to app user and filesystem/memory to node user.
teddiesloco
force-pushed
the
fix/dockerfile-non-root-user
branch
from
September 3, 2026 18:06
e6baebb to
b69718b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #4741.
Since #2205, the Python Dockerfiles (
fetch,git,time) created anappuser with--chown=app:app, but never included aUSER appinstruction before theENTRYPOINT. As a result, containers ran as UID 0 (root).Similarly, the Node images (
filesystem,memory, etc.) inherit fromnode:22-alpinewhich ships with a non-rootnodeuser (UID 1000) that was previously unused.This PR:
useraddcheck andUSER appto Python Dockerfiles (src/fetch,src/git,src/time).USER nodebeforeENTRYPOINTto Node Dockerfiles (src/filesystem,src/memory).runAsNonRoot: truepolicies.