[rush] Remove deprecated shell: true usage. #5496
Merged
+151
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
D4N14L,
apostolisms,
dmichon-msft and
octogonz
as code owners
iclanton
force-pushed
the
remove-rush-shell
branch
3 times, most recently
from
d1a9093 to
0b99d96
Compare
iclanton
commented
Dec 30, 2025
iclanton
commented
Dec 30, 2025
iclanton
added a commit
that referenced
this pull request
Jan 3, 2026
* Remove deprecated shell: true usage. * Stop quoting args. * TEMPORARY - run retest fromt he locally-built copy of Rush. * Fix an issue where where the Windows CMD shell's arguments aren't passed as individual arguments. * Don't escape individual args in RushX, as they're passed to cmd/sh. * fixup! Remove deprecated shell: true usage. * Remove an unused function. * Use destructuring in a few places. * Fix an issue with detecting if a package isn't published. * Wrap some command invocations in a shell. * Fix an issue with detection of non-published packages. * fixup! Wrap some command invocations in a shell. * fixup! Fix an issue with detection of non-published packages. * Fix issues with install-run on Windows. * TEMPORARY - ensure install-run works as expected. * Fix an issue with commands and arguments containing spaces. * fixup! Fix an issue with commands and arguments containing spaces. * fixup! TEMPORARY - ensure install-run works as expected. * fixup! TEMPORARY - ensure install-run works as expected. * TEMPORARY - install-run debugging. * fixup! TEMPORARY - install-run debugging. * Fix issues with git calls in stageAndCommitGitChangesAsync Co-authored-by: David Michon <dmichon@microsoft.com> * Deduplicate instances of the Windows platform check. * Include unit tests for convertCommandAndArgsToShell. * Remove a redundant condition. * Clean up an error message. * Fix an issue with double-quoting in install-run. * TEMPORARY - only build to rush-lib. * fixup! Fix an issue with double-quoting in install-run. * Don't run as a shell command on Windows. * fixup! TEMPORARY - only build to rush-lib. * Revert "Don't run as a shell command on Windows." This reverts commit 1fa9d41. * Pass 'process.env' to the 'npm view' command. * Handle null status code too. * fixup! Fix an issue with double-quoting in install-run. * Set windowsVerbatimArguments to true in places where spawn is called with a shell wrapper. * Fix an issue with quoting of arguments. * fixup! Set windowsVerbatimArguments to true in places where spawn is called with a shell wrapper. * fixup! Fix an issue with quoting of arguments. * Revert "fixup! TEMPORARY - install-run debugging." This reverts commit 10ff217. * Revert "TEMPORARY - install-run debugging." This reverts commit 2640932. * Pull back shell: true changes. * Rush change. * fixup! Pull back shell: true changes. * Put the CI config back. * Include signals in install-run npm command logging. * Minor cleanup. * Remove an unused function. * Move convertCommandAndArgsToShell into Utilities. --------- Co-authored-by: David Michon <dmichon@microsoft.com>
iclanton
force-pushed
the
remove-rush-shell
branch
from
1620344 to
62e5098
Compare
dmichon-msft
approved these changes
Jan 3, 2026
iclanton
force-pushed
the
remove-rush-shell
branch
from
7e506d4 to
cdfb0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a prerequisite for #5379. See that PR for discussion relevant to this PR.
How it was tested
This PR has been published as
@microsoft/rush-lib@5.165.0-pr5496.2.