Skip to content

[rush] Changes prior to https://github.com/microsoft/rushstack/pull/5496 #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iclanton merged 49 commits into from
Jan 3, 2026
Merged

[rush] Changes prior to https://github.com/microsoft/rushstack/pull/5496 #5532

iclanton merged 49 commits into from
Jan 3, 2026

Conversation

@iclanton
Copy link
Member

@iclanton iclanton commented Jan 2, 2026

Summary

This is some cleanup and ergonomic changes before the shell: true removal change in #5496. I've pulled this out to make the changes in that PR cleaner after this goes in.

How it was tested

Built + ran unit tests.

Impacted documentation

None.

iclanton and others added 30 commits December 29, 2025 15:43
@iclanton
Remove deprecated shell: true usage.
2e4a040
@iclanton
Stop quoting args.
4806860
@iclanton
TEMPORARY - run retest fromt he locally-built copy of Rush.
2615d60
@iclanton
Fix an issue where where the Windows CMD shell's arguments aren't pas…
1d06c90 
…sed as individual arguments.
@iclanton
Don't escape individual args in RushX, as they're passed to cmd/sh.
30aa684
@iclanton
fixup! Remove deprecated shell: true usage.
747b577
@iclanton
Remove an unused function.
9a7788f
@iclanton
Use destructuring in a few places.
95967f7
@iclanton
Fix an issue with detecting if a package isn't published.
50f199e
@iclanton
Wrap some command invocations in a shell.
041c3e3
@iclanton
Fix an issue with detection of non-published packages.
2ec0163
@iclanton
fixup! Wrap some command invocations in a shell.
6e9461d
@iclanton
fixup! Fix an issue with detection of non-published packages.
0b99d96
@iclanton
Fix issues with install-run on Windows.
18ea31d
@iclanton
TEMPORARY - ensure install-run works as expected.
31af73d
@iclanton
Fix an issue with commands and arguments containing spaces.
547ddae
@iclanton
fixup! Fix an issue with commands and arguments containing spaces.
12013a3
@iclanton
fixup! TEMPORARY - ensure install-run works as expected.
095f767
@iclanton
fixup! TEMPORARY - ensure install-run works as expected.
35ec6e5
@iclanton
TEMPORARY - install-run debugging.
2640932
@iclanton
fixup! TEMPORARY - install-run debugging.
10ff217
@iclanton @dmichon-msft
Fix issues with git calls in stageAndCommitGitChangesAsync
46c6a8a 
Co-authored-by: David Michon <dmichon@microsoft.com>
@iclanton
Deduplicate instances of the Windows platform check.
e8d24fc
@iclanton
Include unit tests for convertCommandAndArgsToShell.
9d968c4
@iclanton
Remove a redundant condition.
7bedc16
@iclanton
Clean up an error message.
00f1fb1
@iclanton
Fix an issue with double-quoting in install-run.
3abde56
@iclanton
TEMPORARY - only build to rush-lib.
b17972d
@iclanton
fixup! Fix an issue with double-quoting in install-run.
cb0fdd2
@iclanton
Don't run as a shell command on Windows.
1fa9d41
iclanton added 13 commits January 1, 2026 22:42
@iclanton
fixup! TEMPORARY - only build to rush-lib.
8f31ce2
@iclanton
Revert "Don't run as a shell command on Windows."
1385af7 
This reverts commit 1fa9d41.
@iclanton
Pass 'process.env' to the 'npm view' command.
3e96b58
@iclanton
Handle null status code too.
913e518
@iclanton
fixup! Fix an issue with double-quoting in install-run.
a56d108
@iclanton
Set windowsVerbatimArguments to true in places where spawn is called …
763aed5 
…with a shell wrapper.
@iclanton
Fix an issue with quoting of arguments.
fc02fe0
@iclanton
fixup! Set windowsVerbatimArguments to true in places where spawn is …
011d551 
…called with a shell wrapper.
@iclanton
fixup! Fix an issue with quoting of arguments.
1620344
@iclanton
Revert "fixup! TEMPORARY - install-run debugging."
19f6446 
This reverts commit 10ff217.
@iclanton
Revert "TEMPORARY - install-run debugging."
53771ce 
This reverts commit 2640932.
@iclanton
Pull back shell: true changes.
c139440
@iclanton
Rush change.
8ff5f9e
@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Jan 2, 2026
dmichon-msft
dmichon-msft approved these changes Jan 2, 2026
View reviewed changes
@iclanton iclanton enabled auto-merge (squash) January 3, 2026 00:18
@iclanton iclanton merged commit 1429229 into microsoft:main Jan 3, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from Needs triage to Closed in Bug Triage Jan 3, 2026
@iclanton iclanton deleted the pre-remove-rush-shell branch January 3, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmichon-msft dmichon-msft dmichon-msft approved these changes

@octogonz octogonz Awaiting requested review from octogonz octogonz is a code owner

@apostolisms apostolisms Awaiting requested review from apostolisms apostolisms is a code owner

@D4N14L D4N14L Awaiting requested review from D4N14L D4N14L is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Bug Triage
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iclanton @dmichon-msft