Skip to content

FIX: always statically link simdutf via FetchContent #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bewithgaurav merged 5 commits into from
Jun 3, 2026
+13 −17
Merged

FIX: always statically link simdutf via FetchContent #608

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e5d4aa
FIX: always statically link simdutf via FetchContent on macOS
edgarrmondragon May 29, 2026
75e9287
Merge branch 'main' into fix/macos-wheel-simdutf-dynamic-link
jahnvi480 Jun 1, 2026
66750d0
Merge branch 'main' into fix/macos-wheel-simdutf-dynamic-link
bewithgaurav Jun 2, 2026
160ec82
Merge branch 'main' into fix/macos-wheel-simdutf-dynamic-link
bewithgaurav Jun 2, 2026
712ae36
Merge branch 'main' into fix/macos-wheel-simdutf-dynamic-link
jahnvi480 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions mssql_python/pybind/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,24 +215,20 @@ endif()

message(STATUS "Final Python library directory: ${PYTHON_LIB_DIR}")

find_package(simdutf CONFIG QUIET)

if(NOT simdutf_FOUND)
include(FetchContent)
message(STATUS "simdutf not found via find_package; downloading v8.2.0 source archive with FetchContent")
set(simdutf_fetchcontent_args
URL https://github.com/simdutf/simdutf/archive/refs/tags/v8.2.0.tar.gz
URL_HASH SHA256=033a91b1d7d1cb818c1eff49e61faaa1b64a3a530d59ef9efef0195e56bda8b1
)
if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.24")
list(APPEND simdutf_fetchcontent_args DOWNLOAD_EXTRACT_TIMESTAMP FALSE)
endif()
FetchContent_Declare(simdutf ${simdutf_fetchcontent_args})
set(SIMDUTF_TESTS OFF CACHE BOOL "Disable simdutf tests" FORCE)
set(SIMDUTF_TOOLS OFF CACHE BOOL "Disable simdutf tools" FORCE)
set(SIMDUTF_BENCHMARKS OFF CACHE BOOL "Disable simdutf benchmarks" FORCE)
FetchContent_MakeAvailable(simdutf)
include(FetchContent)
message(STATUS "Downloading simdutf v8.2.0 source archive with FetchContent")
set(simdutf_fetchcontent_args
URL https://github.com/simdutf/simdutf/archive/refs/tags/v8.2.0.tar.gz
URL_HASH SHA256=033a91b1d7d1cb818c1eff49e61faaa1b64a3a530d59ef9efef0195e56bda8b1
)
if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.24")
list(APPEND simdutf_fetchcontent_args DOWNLOAD_EXTRACT_TIMESTAMP FALSE)
endif()
FetchContent_Declare(simdutf ${simdutf_fetchcontent_args})
set(SIMDUTF_TESTS OFF CACHE BOOL "Disable simdutf tests" FORCE)
set(SIMDUTF_TOOLS OFF CACHE BOOL "Disable simdutf tools" FORCE)
set(SIMDUTF_BENCHMARKS OFF CACHE BOOL "Disable simdutf benchmarks" FORCE)
FetchContent_MakeAvailable(simdutf)

set(DDBC_SOURCE "ddbc_bindings.cpp")
Comment thread
edgarrmondragon marked this conversation as resolved.
message(STATUS "Using standard source file: ${DDBC_SOURCE}")
Expand Down
Loading