FIX: always statically link simdutf via FetchContent#608
Merged
bewithgaurav merged 5 commits intoJun 3, 2026
Merged
Conversation
Closes microsoft#607 Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the optional find_package(simdutf) lookup and always fetches simdutf v8.2.0 via FetchContent.
Changes:
- Eliminates the
find_package(simdutf CONFIG QUIET)check and the surrounding conditional branch - Makes the FetchContent download of simdutf v8.2.0 unconditional
- Dedents the FetchContent configuration accordingly
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edgarrmondragon
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.7%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 76.1%
mssql_python.row.py: 76.9%
mssql_python.__init__.py: 77.3%
mssql_python.pybind.connection.connection.cpp: 77.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.logging.py: 85.5%
mssql_python.connection.py: 85.6%🔗 Quick Links
|
Collaborator
|
/azp run |
bewithgaurav
approved these changes
Jun 3, 2026
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jahnvi480
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
The published macOS universal2 wheel dynamically links simdutf against a Homebrew path baked in at CI build time, causing an import failure on any machine that doesn't have simdutf installed at that exact path.
Fix: remove the find_package(simdutf) call in CMakeLists.txt so FetchContent is always used, which builds simdutf as a static library and embeds its symbols directly into the extension.