[SM6.10] LinAlg: Add Convert Signedness Test - #8955
Merged
Ashley Coleman (V-FEXrt) merged 1 commit intoSep 23, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Ashley Coleman (V-FEXrt)
September 23, 2026 16:18
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused test changes are correct, and no unresolved issues were found.
Review effort: Balanced
Findings: None
What changed in this PR
Adds SM 6.10 CodeGen coverage for signed and unsigned 64-bit LinAlg Convert outputs.
Changes:
- Corrects the
int64_tinterpretation toI64. - Adds a
uint64_tcase usingU64.
| File | Description |
|---|---|
tools/clang/test/CodeGenDXIL/hlsl/linalg/builtins/convert/nominal.hlsl |
Verifies signed and unsigned 64-bit conversion interpretations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Helena Kotas (hekota)
approved these changes
Sep 23, 2026
Finn Plummer (inbelic)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8355