Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Bluedroid rejects a notification (for example before notification subscription or during stack congestion), checkRecvFrame() still removes that response from the outgoing queue. Retain it until the synchronous SUCCESS_NOTIFY callback confirms submission, preserving the existing 60 ms pacing. Report a full outgoing queue as busy and defer queued commands until there is space for their reply.
All 98 host tests pass. Five new tests compile the actual ESP32 transport against BLE/FreeRTOS fakes; four fail on unpatched dev. They cover failed submission/retry order, subscription delay, stale success state, reply capacity, and disconnect cleanup. The Heltec V4 TFT BLE firmware build passes. A v1.18.0-based Heltec V4 TFT test build with this patch, #3831, and a local Bluetooth-name length guard completed contact/channel sync with MeshCore iOS 1.51.1. Recurring 0x08 link timeouts still occurred, so the short successful sync runs do not establish connection stability or isolate this patch’s effect.
Remaining validation: actual iPhone reconnect/sync behavior, sustained notification failures, and rapid reconnect timing. A persistent send failure currently keeps the head frame queued and can stall command processing or paced streams until sending succeeds or disconnect cleanup occurs; a bounded recovery policy needs review. SUCCESS_NOTIFY confirms submission to the stack, not receipt by the phone. The four-frame incoming burst limit is unchanged, and these tests do not exercise real controller timing or concurrency. This does not establish or fix the cause of recurring RF/encryption disconnects.
Related: #3633 proposes a broader BLE replacement; this patch is limited to the existing Bluedroid transport. Draft for human review and hardware validation, opened at the contributor's explicit request. Prepared with AI assistance; human line-by-line review is still pending.