Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP32 BLE disconnect logs currently omit the stack reason, making recurring iPhone timeouts difficult to investigate. Log the disconnect connection ID, reason and uptime, and include the authentication failure reason. Connection handling is unchanged; the additional fields remain behind BLE_DEBUG_LOGGING and contain no PINs, peer addresses or message contents.
The Heltec V4 TFT BLE firmware build passes. Hardware testing on a Heltec V4 TFT running v1.18.0 plus this patch, #3832, and a local Bluetooth-name length guard captured recurring disconnect reason 0x08 (connection timeout), successful authentication between reconnects, and increasing uptime. This confirms that the added diagnostics work; it does not fix the disconnects reported in #1835.
Draft for human review and hardware validation, opened at the contributor's explicit request. Prepared with AI assistance; human line-by-line review is still pending. Related broader BLE migration: #3633.