Skip to content

fix: ESPNowBridge recv callback signature breaks build on RISC-V ESP32 (C3/C6) #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syssi wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: ESPNowBridge recv callback signature breaks build on RISC-V ESP32 (C3/C6) #3186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/helpers/bridges/ESPNowBridge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
ESPNowBridge *ESPNowBridge::_instance = nullptr;

// Static callback wrappers
void ESPNowBridge::recv_cb(const uint8_t *mac, const uint8_t *data, int32_t len) {
void ESPNowBridge::recv_cb(const uint8_t *mac, const uint8_t *data, int len) {
if (_instance) {
_instance->onDataRecv(mac, data, len);
}
Expand Down Expand Up @@ -100,7 +100,7 @@ void ESPNowBridge::xorCrypt(uint8_t *data, size_t len) {
}
}

void ESPNowBridge::onDataRecv(const uint8_t *mac, const uint8_t *data, int32_t len) {
void ESPNowBridge::onDataRecv(const uint8_t *mac, const uint8_t *data, int len) {
// Ignore packets that are too small to contain header + checksum
if (len < (BRIDGE_MAGIC_SIZE + BRIDGE_CHECKSUM_SIZE)) {
BRIDGE_DEBUG_PRINTLN("RX packet too small, len=%d\n", len);
Expand Down
4 changes: 2 additions & 2 deletions src/helpers/bridges/ESPNowBridge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
class ESPNowBridge : public BridgeBase {
private:
static ESPNowBridge *_instance;
static void recv_cb(const uint8_t *mac, const uint8_t *data, int32_t len);
static void recv_cb(const uint8_t *mac, const uint8_t *data, int len);
static void send_cb(const uint8_t *mac, esp_now_send_status_t status);

/**
Expand Down Expand Up @@ -90,7 +90,7 @@ class ESPNowBridge : public BridgeBase {
* @param data Received data
* @param len Length of received data
*/
void onDataRecv(const uint8_t *mac, const uint8_t *data, int32_t len);
void onDataRecv(const uint8_t *mac, const uint8_t *data, int len);

/**
* ESP-NOW send callback
Expand Down