fix: ESPNowBridge recv callback signature breaks build on RISC-V ESP32 (C3/C6) - #3186
Open
syssi wants to merge 1 commit into
Open
fix: ESPNowBridge recv callback signature breaks build on RISC-V ESP32 (C3/C6)#3186syssi wants to merge 1 commit into
syssi wants to merge 1 commit into
Conversation
…2 (C3/C6) esp_now_recv_cb_t expects a plain 'int' for the data-length parameter. On Xtensa targets int32_t happens to be typedef'd as int, so it built fine, but on RISC-V targets (e.g. ESP32-C3) int32_t is 'long int' -- a distinct type from 'int' even though both are 32-bit -- so the function pointer conversion is rejected outright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esp_now_recv_cb_t expects a plain int for the data length parameter. On Xtensa targets int32_t happens to be typedef'd as int, so it built fine, but on RISC-V targets (e.g. ESP32-C3) int32_t is long int, a distinct type from int even though both are 32 bit, so the function pointer conversion is rejected outright.
This was never caught before because CI never built the *_repeater_bridge_espnow environments for RISC-V boards. Confirmed the build failure against current dev on Tenstar_C3_sx1262_repeater_bridge_espnow before this fix, and confirmed the fix resolves it.
Changes
How to reproduce
Expected result before this fix:
Test plan