Repository navigation
docs(upstream-drift): record the cleaned-state gate deferral and its trigger - #13595
Conversation
…trigger Records owner decision Q-9759-2 (b) of 2026-11-05: the cleaned-state CI gate is deferred until a disposition sweep applies at least one disposition. Adds the re-derive trigger and what is built then, and a 4.2.1 patch entry in the contract changelog. Refs #9759 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e9c321a1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
claude-security-review reviewed Security review: PR #13595 (incremental, 1e9c321 → 89f6a5b)No security issues found. I read every hunk of both files in the incremental scope:
What changed since the last review. Documentation wording only:
Why this is out of security scope.
Settled threads. Both threads on PR context. The description and the closing-issue comments contain no text that tries to direct this review. Prior findings. The earlier review of 1e9c321 reported 0 findings. Because critical-findings: 0 |
|
claude-review reviewed Code review (incremental, 1e9c321 → 89f6a5b): no findingsBlocking only. This lane already reviewed an earlier head of this pull request, so this review reports only blocking findings and drops advisory ones. I read every hunk of both files in scope, This push fixes the earlier inline finding. The README record now uses the canonical label The corrected deferral reason matches the sources it cites. README.md:533-536 now says one class is fix-eligible, near-verbatim, declared on 2026-11-02, and that this supersedes the 2026-10-30 ruling. I checked the citations:
The new reason, that the gate waits on the first applied disposition rather than on an eligible class, still fits Q-9759-2 (b) and the trigger. Other notes
|
State that near-verbatim findings are fix-eligible since 2026-11-02 and the gate waits on the first applied disposition, and use the canonical "Recheck trigger" label. Refs #9759 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The pr-verify verifier failed head What it wrote (22 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
Refs: #9759
Summary
#9759 is slice 3 of #3465. Its four steps:
docs/contracts/upstream-drift/CHANGELOG.mdunder 4.2.0 ("The hash-store deferral trigger fired, on its second event") and in the "Drift signal: content hashing, deferred" section ofdocs/contracts/upstream-drift/README.md. docs(upstream-drift): record the provenance convention engagement as 4.2.0 #13461 changed exactly those two files.Fix
Adds "Recorded decision: the cleaned-state gate is deferred until a sweep applies a disposition" to
docs/contracts/upstream-drift/README.md, after the adoption-gate decision. It states the decision, why (0 dispositions applied on 2026-11-04, one class (fingerprint-confirmed near-verbatim) fix-eligible since the 2026-11-02 owner decision but none applied, and the sweep's zero is not evidence the repository is clean), the recheck trigger (the first sweep that applies at least one disposition, recorded on #3465 or its successor), and what is built then (a gate step inpr-require-checks.ymlwith a failing and a passing.test.shfixture). Adds a 4.2.1 patch entry to the contract CHANGELOG.Verification
Remaining
This PR delivers the step 4 deferral record. Steps 1 and 2 shipped in #13461 and step 3 in #13549 with melodic-software/ci-workflows#993. What remains on #9759 is Fix step 4 and done-when item 3: the cleaned-state gate step in
pr-require-checks.ymlwith a failing and a passing.test.shfixture. The owner's Q-9759-2 (b) defers it until a disposition sweep applies at least one disposition, the recheck trigger this PR records. #9759 stays open as that gate's tracker.Related
provenance sweep sub-topic: repo-wide sweep, upstream-drift convention engagement, and the cleaned-state gate #3465: the sweep record whose first applied disposition fires the gate's recheck trigger.
provenance sweep sub-topic: repo-wide sweep, upstream-drift convention engagement, and the cleaned-state gate #3465, attribution: run the disposition-applying provenance sweep once a class is fix-eligible #9755, docs(upstream-drift): record the provenance convention engagement as 4.2.0 #13461, feat(ci): file one issue per dead link the online link check finds #13549
Owner decision: upstream-drift: record the provenance convention entry and add the cleaned-state CI gate #9759 (comment)
🤖 Generated with Claude Code