Repository navigation
chore(attribution): restore the bundled fixture exclusions to close the provenance sweep - #13643
Conversation
…epository's config docs/conventions/attribution.yaml set excluded_paths to "**/evals/fixtures/**" before the plugin's 0.16.0 default declined every test-fixture tree. A layer that sets the key replaces the default whole (plugins/attribution/skills/setup/reference/keys.md "The test-fixture exclusion"), so script fixtures such as scripts/fixtures/hooks-lifecycle-table.md, a saved copy of the Hooks reference lifecycle table that scripts/gen-hook-event-registry.test.sh reads, were audited as prose and reached every fix gate. The list now carries the default's three globs. The fixture's disposition is a categorical keep, not a per-instance suppression. The repository corpus goes from 277 declined files to 485: 462 under **/fixtures/**, 2 under **/testdata/**, 21 vendored. Refs: #3465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RMa441wb9nbFwyTS8nqdYj
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
claude-security-review reviewed Security review (incremental, blocking only): no security issues foundScope: I read all of the change since What changed: only the YAML header comment. It now says that the eval harness's config isolation lifts the bundled test-fixture default, so eval fixtures still report their real findings, and it cites the What I checked:
Spend: none. critical-findings: 0 |
|
claude-review reviewed Code review: PR #13643, changes since
|
… applies Review on #13643: copying the default's globs into this layer changed their behavior. list-corpus.sh matches a config-layer list against full repository paths, so a named fixture is declined. The bundled default is matched below the scan target and skips a named file. With the key unset, fixture and testdata trees are still declined in a repo-wide run, and a run aimed at a fixture reads it. Refs: #3465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RMa441wb9nbFwyTS8nqdYj
|
The pr-verify verifier failed head What it wrote (28 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
pr-verify on #13643: the earlier comment said the eval harness's config isolation lifts the fixture exclusion. The bundled default keeps that property (list-corpus.sh header), and the config comment says so again. Refs: #3465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RMa441wb9nbFwyTS8nqdYj
Refs: #3465
Summary
This PR delivers the fixture disposition for the provenance sweep sub-topic: the repository config now lets the attribution plugin's bundled test-fixture exclusion apply. The sweep that produced it,
attribution-3465-close-20261106T023054Z, also covered the two other gaps in #3465's 2026-11-06 close audit. That evidence is in an issue comment (record), not in this diff.Each #3465 checklist item and where it stands:
min_n_per_classnot-foundprobecheck-catalog.md:414-419: search 1 of 3 found the source, fetch 1 of 5 confirmed it (record)leave-with-reason, and the durable keep is this PRFix
docs/conventions/attribution.yaml:excluded_pathsis removed. A layer's list replaces the bundled default whole (plugins/attribution/schemas/attribution.schema.json:12), so the repository's single**/evals/fixtures/**entry had silently dropped that default. The default also behaves differently from a copied list: it is matched below the scan target and skipped for a file named directly (list-corpus.sh:15-16,:305-313). The first cut copied its globs instead, and review showed that would decline a named fixture.list-corpus.sh:17-19).Verification
list-corpus.shon this branch: a repo-wide run declines 485 files under the bundled default reason, up from 277, so 208 more files in fixture and testdata trees are no longer audited as prose.scripts/fixtures/hooks-lifecycle-table.mdnamed directly reads 1 included, 0 declined.Remaining
docs/contracts/upstream-drift/README.md. Under the owner's 2026-11-05 direction, hardening-tied work closes and is rediscovered one item at a time. So provenance sweep sub-topic: repo-wide sweep, upstream-drift convention engagement, and the cleaned-state gate #3465 closes by hand once this lands, as upstream-drift: record the provenance convention entry and add the cleaned-state CI gate #9759 did.Related
Follow-ups
plugins/machine-health/skills/audit/reference/windows/check-catalog.md:414-419restates the Task Scheduler constants. The recommended disposition iscondense-to-stamped-record, pointing at Microsoft's constants page, for a human to apply.🤖 Generated with Claude Code
https://claude.ai/code/session_01RMa441wb9nbFwyTS8nqdYj