Skip to content

fix: chore(attribution, review, multi-agent and five more): call the cascade's personal layer the #13333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melodic-automation-lanes wants to merge 5 commits into from
Closed

fix: chore(attribution, review, multi-agent and five more): call the cascade's personal layer the #13333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d74488
Resolve issue #13191
melodic-automation-lanes[bot] Nov 4, 2026
8b8daf3
Merge main into work-resolve-issue/issue-13191-41889151702-1
melodic-automation-lanes[bot] Nov 4, 2026
1ba0fa7
Address review feedback on work-resolve-issue/issue-13191-41889151702-1
melodic-automation-lanes[bot] Nov 4, 2026
76520ff
Address review feedback on work-resolve-issue/issue-13191-41889151702-1
melodic-automation-lanes[bot] Nov 4, 2026
26ee192
Address review feedback on work-resolve-issue/issue-13191-41889151702-1
melodic-automation-lanes[bot] Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/attribution/work-resolve-issue-issue-13191-41889151702-1-4462e5d9.md
View file
Open in desktop

@github-actions github-actions Bot Nov 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 1ba0fa776b89f72bcc48c844f8965dad4e3ffa90. What it wrote, as data:

What it wrote (29 lines) 
Summary: Issue #13191 asks for eight plugins (attribution, review, multi-agent, code-metrics,
  improvement, discipline, bugs, codebase-health) to call the config cascade's personal layer the
  "personal override" in their setup text, config references, READMEs, resolver scripts and tests,
  retirements.yaml, schemas and evals, and for the `check-vocabulary --sense overlay` Demo over
  those plugins to exit 0. The diff from base 249619c to head 1ba0fa7 doesn't contain that work. It
  adds eight `.changes/` fragments and changes one line of `docs/conventions/review-digest.md`. None
  of the ~82 plugin, script and test edits the PR body lists are in it: no change to
  resolve-roles.sh, digest-policy.mjs, concat-gotchas.sh, resolve-config.py, setup scripts, tests,
  evals, scripts/vocabulary-senses.json or retirements.yaml. The spec has no credited_siblings or
  person_checks, so nothing excuses the missing items. The Demo item is unsettled because no job is
  shown to have run check-vocabulary. test-bash (0) passed
  (https://github.com/melodic-software/claude-code-plugins/actions/runs/41903407309/job/126831746501).
  test-node and test-python were skipped, which fits a diff with no code in it. As written, the
  fragments record behavior changes, including two minor bumps for output-label changes, that this
  diff does not make. The review fragment also disagrees with the doc line this PR changes. Nothing
  in the PR text looked like an attempt to steer the reviewer. No credentials, binary files or
  takeover-set files are touched.
- plugins/: the diff has none of the renames issue #13191 requires in the eight plugins (setup and
  skill text, config references, READMEs, resolve-roles.sh, digest-policy.mjs, concat-gotchas.sh,
  resolve-config.py, setup scripts and their tests, retirements.yaml, evals). Add these changes to
  the branch so the diff against base delivers them, or, if they are already at base through another
  PR, name that PR on a Siblings: line and drop the fragments that record its work.
- scripts/check-vocabulary.py: the done-when item 'the Demo command exits 0' is not shown to have
  run on this head. Make sure the diff contains the plugin changes the Demo checks, and that a CI
  job running check-vocabulary --sense overlay over the eight plugins passes.
- .changes/attribution/work-resolve-issue-issue-13191-41889151702-1-4462e5d9.md: this fragment and
  the bugs, code-metrics, codebase-health, discipline and improvement fragments describe wording and
  script changes that are not in this diff. Each fragment must describe a change the PR actually
  makes; drop or rewrite any that don't.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

No release needed: this pull request changes no attribution file. The personal override rename (#13191) is already on the base and recorded by its chore-13191-personal-override-eight fragment.
5 changes: 5 additions & 0 deletions .changes/bugs/work-resolve-issue-issue-13191-41889151702-1-9d2b4dc9.md
View file
Open in desktop

@github-actions github-actions Bot Nov 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 76520ff79cfd003f9900b37461f2179f03f01eb0. What it wrote, as data:

What it wrote (25 lines) 
Summary: Issue #13191 asks for eight plugins (attribution, review, multi-agent, code-metrics,
  improvement, discipline, bugs, codebase-health) to call the config cascade's personal layer the
  "personal override" in their skill text, config references, READMEs, resolver and setup scripts
  with their tests, retirements.yaml, schemas and evals, with `check-vocabulary --sense overlay`
  exiting 0 over those plugins. The PR body describes about 82 changed files. The judged diff (base
  249619c to head 76520ff) changes only nine: eight new `.changes/*` fragments and one line in
  docs/conventions/review-digest.md. No file under plugins/ is touched, so resolve-roles.sh,
  digest-policy.mjs, concat-gotchas.sh, setup.sh, the SKILL.md files, the evals and the tests that
  the fragments describe are not in this diff. Nothing in the diff shows the Demo outcome is met.
  Consistent with that, test-node and test-python were skipped and nothing ran the plugin suites.
  The fragments therefore describe changes this diff does not ship, which makes the release records
  inaccurate unless the work is already at the base. If it is, the fragments duplicate it. No
  capture summary was present. No secrets, takeover-set files or steering text found.
- plugins/: the diff has no change under any of the eight plugins. Restore or re-apply the rename,
  so the head actually delivers the Outcome and `check-vocabulary --sense overlay` exits 0 over the
  eight plugins. That means the label changes in multi-agent resolve-roles.sh and setup.sh, review
  digest-policy.mjs and bugs concat-gotchas.sh with their tests, plus the skill, reference, README,
  retirements.yaml and eval wording. Alternatively, show that the base already has this work and
  drop the duplicate fragments.
- .changes/attribution, .changes/code-metrics, .changes/codebase-health, .changes/discipline,
  .changes/improvement: each patch fragment describes wording changes that are absent from the diff.
  Ship the matching plugin edits, or remove the fragments.
- .changes/bugs/work-resolve-issue-issue-13191-41889151702-1-9d2b4dc9.md: this fragment says
  concat-gotchas.sh now prints `#### personal override (...)`, but concat-gotchas.sh and its test
  are not in the diff. Ship those changes, or remove the fragment.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

No release needed: this pull request changes no bugs file. The personal override rename (#13191) is already on the base and recorded by its chore-13191-personal-override-eight fragment.
5 changes: 5 additions & 0 deletions .changes/code-metrics/work-resolve-issue-issue-13191-41889151702-1-5b3e7136.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

No release needed: this pull request changes no code-metrics file. The personal override rename (#13191) is already on the base and recorded by its chore-13191-personal-override-eight fragment.
5 changes: 5 additions & 0 deletions .changes/codebase-health/work-resolve-issue-issue-13191-41889151702-1-e2d96514.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

No release needed: this pull request changes no codebase-health file. The personal override rename (#13191) is already on the base and recorded by its chore-13191-personal-override-eight fragment.
5 changes: 5 additions & 0 deletions .changes/discipline/work-resolve-issue-issue-13191-41889151702-1-d3d8b935.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

No release needed: this pull request changes no discipline file. The personal override rename (#13191) is already on the base and recorded by its chore-13191-personal-override-eight fragment.
5 changes: 5 additions & 0 deletions .changes/improvement/work-resolve-issue-issue-13191-41889151702-1-ff586768.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

No release needed: this pull request changes no improvement file. The personal override rename (#13191) is already on the base and recorded by its chore-13191-personal-override-eight fragment.
5 changes: 5 additions & 0 deletions .changes/multi-agent/work-resolve-issue-issue-13191-41889151702-1-aeca15ab.md
View file
Open in desktop

@github-actions github-actions Bot Nov 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 8b8daf3e2f38055cef1960668369355d30c71561. What it wrote, as data:

What it wrote (27 lines) 
Summary: Issue #13191 asks that eight plugins (attribution, review, multi-agent, code-metrics,
  improvement, discipline, bugs, codebase-health) call the config cascade's personal layer the
  "personal override" everywhere: in setup text, config references, READMEs, resolver scripts and
  their tests, retirements.yaml, schemas and evals, so that `check-vocabulary --sense overlay` over
  those plugins exits 0. The pull request body says about 82 files changed. The judged diff (base
  249619c to head 8b8daf3) changes only eight `.changes/` fragments,
  `docs/conventions/review-digest.md` and the vocabulary allowlist
  (`scripts/vocabulary-senses.json`, `scripts/test_check_vocabulary.py`). It changes no file under
  `plugins/`. No credited sibling or person check excuses the missing work. So the Outcome and the
  first done-when item (the Demo exits 0) are not delivered by this diff, and the fragments describe
  changes the diff does not make. Two of them describe output-label changes and ask for minor bumps.
  The CI jobs that ran (test-bash, test-python, check-plugins, check-skills and the others) all
  passed. test-node was skipped, which is expected because the review plugin's Node suite runs
  through its `.test.sh` wrapper. The new `batch overlay` allowlist phrase is reasonable on its own
  and has its required test row. There was no capture summary.
- plugins/: the diff changes no plugin file. Add the plugin-side renames the issue asks for and the
  PR body lists to the branch: multi-agent's resolve-roles.sh and setup.sh, review's
  digest-policy.mjs and its tests, bugs' concat-gotchas.sh, code-metrics' resolve-config.py,
  discipline's sweep-all text, and the setup skill, config reference, README, retirements.yaml and
  eval text. Without them `check-vocabulary --sense overlay` over the eight plugins is not shown to
  exit 0.
- .changes/attribution, bugs, code-metrics, codebase-health, discipline, improvement (the six
  work-resolve-issue-issue-13191-* patch fragments): each describes wording changes in its plugin
  that are absent from the diff. Keep each fragment only together with the plugin change it records.
- .changes/multi-agent/work-resolve-issue-issue-13191-41889151702-1-aeca15ab.md: this minor fragment
  announces a `personal-override` label in resolve-roles.sh and setup.sh that this diff does not
  make. Either ship that change in the branch or remove the fragment.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

No release needed: this pull request changes no multi-agent file. The `personal-override` label in resolve-roles.sh and setup.sh (#13191) is already on the base and recorded by its chore-13191-personal-override-eight fragment.
5 changes: 5 additions & 0 deletions .changes/review/work-resolve-issue-issue-13191-41889151702-1-0a4305b0.md
View file
Open in desktop

@github-actions github-actions Bot Nov 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 8b8daf3e2f38055cef1960668369355d30c71561. What it wrote about this file, as data:

- .changes/review/work-resolve-issue-issue-13191-41889151702-1-0a4305b0.md: this minor fragment
  announces a `personal override <path>` source label in digest-policy.mjs that this diff does not
  make. Either ship that change in the branch or remove the fragment.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
bump: none
---

No release needed: this pull request changes no review plugin file. The `personal-override <path>` source label in digest-policy.mjs (#13191) is already on the base and recorded by its chore-13191-personal-override-eight fragment.
2 changes: 1 addition & 1 deletion docs/conventions/review-digest.md
View file
Open in desktop

@github-actions github-actions Bot Nov 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 8b8daf3e2f38055cef1960668369355d30c71561. What it wrote about this file, as data:

- docs/conventions/review-digest.md:139: the documented source label `personal override <path>` must
  match what digest-policy.mjs emits. The diff does not change that script, so make the code change
  in the branch or keep the doc in line with what the code emits.

Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ an earlier one key by key:
3. personal override `.claude/review-digest.local.json`

The result names the layer that supplied each value (`team <commit>:<path>`, `user-global <path>`,
`overlay <path>`, or `default`). Quote glob values in the YAML file (`"**/hooks/**"`), since a plain
`personal-override <path>`, or `default`). Quote glob values in the YAML file (`"**/hooks/**"`), since a plain
`*` opens an alias.

The team layer, and the rendered-views team file, are read from the pull request's base commit
Expand Down
Loading