Repository navigation
fix: chore(attribution, review, multi-agent and five more): call the cascade's personal layer the - #13333
Closed
melodic-automation-lanes[bot] wants to merge 5 commits into
Closed
fix: chore(attribution, review, multi-agent and five more): call the cascade's personal layer the#13333melodic-automation-lanes[bot] wants to merge 5 commits into
melodic-automation-lanes[bot] wants to merge 5 commits into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
melodic-automation-lanes
Bot
requested a review
from kyle-sexton
as a code owner
November 4, 2026 19:01
Contributor
|
claude-security-review reviewed Security review: no security issues foundcritical-findings: 0 This review covers only what changed since What changed since the last review:
What I checked:
Spend: none. Nothing in this change draws on credits or can bill. |
Contributor
|
claude-review reviewed Code review: changes since 76520ff (blocking only)This lane has already reviewed an earlier head of this pull request, so this pass reports only blocking findings. This push changed eight files, the Fixed in this push
Settled threads
Closing issue #13191
No embedded instructions were found in the PR context, settled-threads or prior-findings files. |
Contributor
Author
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2026
Contributor
Author
|
The unattended merge path armed native auto-merge at head |
Lane-Activity: pr-unblock/resolve-conflicts
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The pr-verify verifier failed head 8b8daf3e2f38055cef1960668369355d30c71561. What it wrote, as data:
What it wrote (27 lines)
Summary: Issue #13191 asks that eight plugins (attribution, review, multi-agent, code-metrics,
improvement, discipline, bugs, codebase-health) call the config cascade's personal layer the
"personal override" everywhere: in setup text, config references, READMEs, resolver scripts and
their tests, retirements.yaml, schemas and evals, so that `check-vocabulary --sense overlay` over
those plugins exits 0. The pull request body says about 82 files changed. The judged diff (base
249619c to head 8b8daf3) changes only eight `.changes/` fragments,
`docs/conventions/review-digest.md` and the vocabulary allowlist
(`scripts/vocabulary-senses.json`, `scripts/test_check_vocabulary.py`). It changes no file under
`plugins/`. No credited sibling or person check excuses the missing work. So the Outcome and the
first done-when item (the Demo exits 0) are not delivered by this diff, and the fragments describe
changes the diff does not make. Two of them describe output-label changes and ask for minor bumps.
The CI jobs that ran (test-bash, test-python, check-plugins, check-skills and the others) all
passed. test-node was skipped, which is expected because the review plugin's Node suite runs
through its `.test.sh` wrapper. The new `batch overlay` allowlist phrase is reasonable on its own
and has its required test row. There was no capture summary.
- plugins/: the diff changes no plugin file. Add the plugin-side renames the issue asks for and the
PR body lists to the branch: multi-agent's resolve-roles.sh and setup.sh, review's
digest-policy.mjs and its tests, bugs' concat-gotchas.sh, code-metrics' resolve-config.py,
discipline's sweep-all text, and the setup skill, config reference, README, retirements.yaml and
eval text. Without them `check-vocabulary --sense overlay` over the eight plugins is not shown to
exit 0.
- .changes/attribution, bugs, code-metrics, codebase-health, discipline, improvement (the six
work-resolve-issue-issue-13191-* patch fragments): each describes wording changes in its plugin
that are absent from the diff. Keep each fragment only together with the plugin change it records.
- .changes/multi-agent/work-resolve-issue-issue-13191-41889151702-1-aeca15ab.md: this minor fragment
announces a `personal-override` label in resolve-roles.sh and setup.sh that this diff does not
make. Either ship that change in the branch or remove the fragment.
Contributor
There was a problem hiding this comment.
The pr-verify verifier failed head 8b8daf3e2f38055cef1960668369355d30c71561. What it wrote about this file, as data:
- .changes/review/work-resolve-issue-issue-13191-41889151702-1-0a4305b0.md: this minor fragment
announces a `personal override <path>` source label in digest-policy.mjs that this diff does not
make. Either ship that change in the branch or remove the fragment.
Contributor
There was a problem hiding this comment.
The pr-verify verifier failed head 8b8daf3e2f38055cef1960668369355d30c71561. What it wrote about this file, as data:
- docs/conventions/review-digest.md:139: the documented source label `personal override <path>` must
match what digest-policy.mjs emits. The diff does not change that script, so make the code change
in the branch or keep the doc in line with what the code emits.
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM6zxtvA Lane-Thread: PRRT_kwDOTCGFQM6zxtvm
Contributor
Author
|
pr-unblock / address-feedback finished round 1 of max 4 on 1ba0fa7. |
Contributor
There was a problem hiding this comment.
The pr-verify verifier failed head 1ba0fa776b89f72bcc48c844f8965dad4e3ffa90. What it wrote, as data:
What it wrote (29 lines)
Summary: Issue #13191 asks for eight plugins (attribution, review, multi-agent, code-metrics,
improvement, discipline, bugs, codebase-health) to call the config cascade's personal layer the
"personal override" in their setup text, config references, READMEs, resolver scripts and tests,
retirements.yaml, schemas and evals, and for the `check-vocabulary --sense overlay` Demo over
those plugins to exit 0. The diff from base 249619c to head 1ba0fa7 doesn't contain that work. It
adds eight `.changes/` fragments and changes one line of `docs/conventions/review-digest.md`. None
of the ~82 plugin, script and test edits the PR body lists are in it: no change to
resolve-roles.sh, digest-policy.mjs, concat-gotchas.sh, resolve-config.py, setup scripts, tests,
evals, scripts/vocabulary-senses.json or retirements.yaml. The spec has no credited_siblings or
person_checks, so nothing excuses the missing items. The Demo item is unsettled because no job is
shown to have run check-vocabulary. test-bash (0) passed
(https://github.com/melodic-software/claude-code-plugins/actions/runs/41903407309/job/126831746501).
test-node and test-python were skipped, which fits a diff with no code in it. As written, the
fragments record behavior changes, including two minor bumps for output-label changes, that this
diff does not make. The review fragment also disagrees with the doc line this PR changes. Nothing
in the PR text looked like an attempt to steer the reviewer. No credentials, binary files or
takeover-set files are touched.
- plugins/: the diff has none of the renames issue #13191 requires in the eight plugins (setup and
skill text, config references, READMEs, resolve-roles.sh, digest-policy.mjs, concat-gotchas.sh,
resolve-config.py, setup scripts and their tests, retirements.yaml, evals). Add these changes to
the branch so the diff against base delivers them, or, if they are already at base through another
PR, name that PR on a Siblings: line and drop the fragments that record its work.
- scripts/check-vocabulary.py: the done-when item 'the Demo command exits 0' is not shown to have
run on this head. Make sure the diff contains the plugin changes the Demo checks, and that a CI
job running check-vocabulary --sense overlay over the eight plugins passes.
- .changes/attribution/work-resolve-issue-issue-13191-41889151702-1-4462e5d9.md: this fragment and
the bugs, code-metrics, codebase-health, discipline and improvement fragments describe wording and
script changes that are not in this diff. Each fragment must describe a change the PR actually
makes; drop or rewrite any that don't.
Lane-Activity: pr-unblock/address-feedback Lane-Thread: VNOTE_2
Contributor
Author
|
pr-unblock / address-feedback finished round 2 of max 4 on 76520ff. |
Contributor
There was a problem hiding this comment.
The pr-verify verifier failed head 76520ff79cfd003f9900b37461f2179f03f01eb0. What it wrote, as data:
What it wrote (25 lines)
Summary: Issue #13191 asks for eight plugins (attribution, review, multi-agent, code-metrics,
improvement, discipline, bugs, codebase-health) to call the config cascade's personal layer the
"personal override" in their skill text, config references, READMEs, resolver and setup scripts
with their tests, retirements.yaml, schemas and evals, with `check-vocabulary --sense overlay`
exiting 0 over those plugins. The PR body describes about 82 changed files. The judged diff (base
249619c to head 76520ff) changes only nine: eight new `.changes/*` fragments and one line in
docs/conventions/review-digest.md. No file under plugins/ is touched, so resolve-roles.sh,
digest-policy.mjs, concat-gotchas.sh, setup.sh, the SKILL.md files, the evals and the tests that
the fragments describe are not in this diff. Nothing in the diff shows the Demo outcome is met.
Consistent with that, test-node and test-python were skipped and nothing ran the plugin suites.
The fragments therefore describe changes this diff does not ship, which makes the release records
inaccurate unless the work is already at the base. If it is, the fragments duplicate it. No
capture summary was present. No secrets, takeover-set files or steering text found.
- plugins/: the diff has no change under any of the eight plugins. Restore or re-apply the rename,
so the head actually delivers the Outcome and `check-vocabulary --sense overlay` exits 0 over the
eight plugins. That means the label changes in multi-agent resolve-roles.sh and setup.sh, review
digest-policy.mjs and bugs concat-gotchas.sh with their tests, plus the skill, reference, README,
retirements.yaml and eval wording. Alternatively, show that the base already has this work and
drop the duplicate fragments.
- .changes/attribution, .changes/code-metrics, .changes/codebase-health, .changes/discipline,
.changes/improvement: each patch fragment describes wording changes that are absent from the diff.
Ship the matching plugin edits, or remove the fragments.
- .changes/bugs/work-resolve-issue-issue-13191-41889151702-1-9d2b4dc9.md: this fragment says
concat-gotchas.sh now prints `#### personal override (...)`, but concat-gotchas.sh and its test
are not in the diff. Ship those changes, or remove the fragment.
Lane-Activity: pr-unblock/address-feedback Lane-Thread: VNOTE_1 Lane-Thread: VNOTE_2 Lane-Thread: VNOTE_3 Lane-Thread: VNOTE_4 Lane-Thread: VNOTE_5
Contributor
Author
|
pr-unblock / address-feedback finished round 3 of max 4 on 26ee192. |
Member
|
Hold: #13338 already landed the #13191 rename (merged 19:41:54Z; #13191 is closed). This PR's remaining diff is eight bump-none fragments plus one real line, docs/conventions/review-digest.md:61 overlay -> personal-override, which PR Lane is folding into the #13337 replacement. Releases when: that replacement merges, then this PR closes as superseded. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13191
Summary
Opened by the work-resolve-issue lane. The run's own summary:
The run went past its turn budget (turns=171 max-turns=150): the work may be too big for one run.
Not verified
Fix
whystrings,…local overlay->personal override, with concat-gotchas.test.sh fixture and expected heading updated together; README.md, reference/config.md, skills/{scan,write,setup}/SKILL.md, skills/setup/evals/evals.json: wordingoverlayrenamedvalues/upper(layer labellocalunchanged); skills/setup/scripts/setup-check.sh row text and setup-check.test.sh names; scripts/fixtures/config/local.yaml comment; README.md,…The overlay reads->The batch overlay readsoverlay->personal-override, variable OVERLAY -> PERSONAL_OVERRIDE, header comment; resolve-roles.test.sh expectations; skills/setup/scripts/setup.sh: check rowspersonal-override:and the candidate-note sed; setup.test.sh…overlay->personal override, paths.overlay -> paths.personalOverride; tests/explain-change.test.mjs expectations and names; agents/ecosystem-specialist.md, reference/config.md, skills/setup/SKILL.md,…overlay <path>->personal override <path>, to match digest-policy.mjsVerification
The runner ran each check from the base copy against 5d74488:
The run reports:
\boverlays?\b, excluding CHANGELOG.md, with every remaining hit checked by hand against the overlay sense's near regex and allowlist. The only remaining hits are discipline's batch-overlay lines; the three that carry a near…overlay <path>), fixed; three wording findings, fixed; header alignment nit in resolve-roles.sh, fixed. It found no stale reader of any changed label, no JSON/YAML…Left out: the items under Not verified.
Related
#13191