Default to ~/.config/gmailctl for newly created config dirs.#455
Open
lgarron wants to merge 2 commits into
Open
Default to ~/.config/gmailctl for newly created config dirs.#455lgarron wants to merge 2 commits into
lgarron wants to merge 2 commits into
Conversation
This was referenced Jun 17, 2026
lgarron
commented
Jun 17, 2026
mbrt
reviewed
Jun 17, 2026
Comment on lines
+153
to
+160
| Configuration and credentials are in a shared directory, either in a default orq | ||
| custom location. | ||
|
|
||
| - `~/.config/gmailctl` — This is the current default location. | ||
| - `~/.gmailctl` — This was the previous default location. `gmailctl` will continue | ||
| to use this location if it exists on your device. | ||
| - Custom location: use the `--config` argument. | ||
|
|
Owner
There was a problem hiding this comment.
Suggested change
| Configuration and credentials are in a shared directory, either in a default orq | |
| custom location. | |
| - `~/.config/gmailctl` — This is the current default location. | |
| - `~/.gmailctl` — This was the previous default location. `gmailctl` will continue | |
| to use this location if it exists on your device. | |
| - Custom location: use the `--config` argument. | |
| Configuration and credentials are in either: | |
| - `<XDG_BASE_DIR>/gmailctl` (using the [XDG base directory spec](https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html), commonly `~/.config/gmailctl` on Linux. | |
| - `~/.gmailctl`: The previous default location. If the directory exists `gmailctl` will continue to use it for backward compatibility | |
| - Custom location: use the `--config` argument. | |
Author
There was a problem hiding this comment.
Yeah, I wasn't sure how verbose to be. Anyhow, it's also the same on macOS (where I use gmailctl).
Owner
There was a problem hiding this comment.
Ah alright, then you can add "and MacOS" as well.
Co-authored-by: Michele Bertasi <405934+mbrt@users.noreply.github.com>
mbrt
approved these changes
Jun 18, 2026
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 37.60% 37.56% -0.05%
==========================================
Files 54 54
Lines 3670 3674 +4
==========================================
Hits 1380 1380
- Misses 2199 2203 +4
Partials 91 91 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal fix for #144
It is a revision of #393 and uses a library for the internal XDG path calculation per feedback there.