Default to ~/.config/gmailctl for newly created config dirs#393
Default to ~/.config/gmailctl for newly created config dirs#393lgarron wants to merge 2 commits into
~/.config/gmailctl for newly created config dirs#393Conversation
This is a minimal fix for mbrt#144
mbrt
left a comment
There was a problem hiding this comment.
Thanks for the contributions!
There are also a bunch of references to the old directory in the main README.md. Could you update them?
I think the new behavior should also be explained in the gmailctl init --help message. Something along the lines that the default config directory location moved from one location to the other.
Sorry for the back and forth, I missed these points in the earlier review. Thanks!
|
I thought about this a bit more and the problem with this PR is that it doesn't solve the problem for all platforms. I think the original issue is more about OSX and Windows, where polluting the home directory with dotfiles is not common. I'm afraid this just introduces one more variant without really tackling the underlying issue. |
I mean, that's fine if you'd prefer to match OS conventions more closely. How would you feel about using https://github.com/adrg/xdg to compute the config path? |
|
Using This should be explained decently in the docs, but I would agree with that change. |
|
This pull request is stale because it has been open for 30 days without activity. |
It's been two years, but I finally got around to this: #455 (I've been using a local build with this PR in the meanwhile.) |
This is a minimal fix for #144