Skip to content

Follow PyQt6 API changes in diverging-mode editor #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnadlinger wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Follow PyQt6 API changes in diverging-mode editor #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions viscm/gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,7 +1185,7 @@ def __init__(self, figurecanvas, viscm_editor, parent=None):
mainlayout.addLayout(min_slider_layout)

if viscm_editor.cmtype == "diverging":
smoothness_slider = QtWidgets.QSlider(Qt.Horizontal)
smoothness_slider = QtWidgets.QSlider(Qt.Orientation.Horizontal)
# We want the slider to vary filter_k exponentially between 5 and
# 1000. So it should go from [log10(5), log10(1000)]
# which is about [0.699, 3.0]
Expand All @@ -1194,15 +1194,15 @@ def __init__(self, figurecanvas, viscm_editor, parent=None):
# to deal with this.
smoothness_slider.setMinimum(699)
smoothness_slider.setMaximum(3000)
smoothness_slider.setTickPosition(QtWidgets.QSlider.NoTicks)
smoothness_slider.setTickPosition(QtWidgets.QSlider.TickPosition.NoTicks)
smoothness_slider.valueChanged.connect(self.smoothness_slider_moved)

# maximum width
smoothness_slider_num = QtWidgets.QLabel("1000.00")
metrics = QtGui.QFontMetrics(smoothness_slider_num.font())
max_width = metrics.width("1000.00")
max_width = metrics.horizontalAdvance("1000.00")
Copy link
Copy Markdown
Author

@dnadlinger dnadlinger May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be boundingRect(…).width().

smoothness_slider_num.setFixedWidth(max_width)
smoothness_slider_num.setAlignment(Qt.AlignRight)
smoothness_slider_num.setAlignment(Qt.AlignmentFlag.AlignRight)
self.smoothness_slider_num = smoothness_slider_num

smoothness_slider_layout = QtWidgets.QHBoxLayout()
Expand Down
Loading