Follow PyQt6 API changes in diverging-mode editor#86
Conversation
| smoothness_slider_num = QtWidgets.QLabel("1000.00") | ||
| metrics = QtGui.QFontMetrics(smoothness_slider_num.font()) | ||
| max_width = metrics.width("1000.00") | ||
| max_width = metrics.horizontalAdvance("1000.00") |
There was a problem hiding this comment.
This could also be boundingRect(…).width().
|
Woops! That was probably my fault :) Thanks for the PR! I'll try and find time to review soon, but ... yeesh. I don't want to promise it'll be quick right now 😬 |
|
Thanks! I'll note that it should be fairly straightforward to review, as it only adds the explicit enum types, like already done in the other places. (No rush – I'm aware that the last commit to |
Whoa, time really flies! That's the exact situation I was in 3 years ago. It doesn't feel like it was 3 years ago though! I was giving a workshop and needed viscm as a visual/exploratory aide for talking about perceptual uniformity. Thanks so much for continuing the cycle and sharing the fixes back :) |
As per the title – it appears the diverging-mode-specific code hasn't been tested since moving to PyQt6 by default.