Repository navigation
Edit a model's configuration sets in the table as a dictionary's - #98
Merged
Merged
Conversation
A model's table is to offer its configuration sets the editing a dictionary's get. The gallery shows the Configurations tiles beside the Model Workspace's classes, each tile naming its section. A set added from a tile lands in Configurations, one edit, with its name editor open. A set is renamed and given a Description, one edit each. A name MATLAB does not give a set is refused in MATLAB's words. A set is deleted, and the active one refused, saying why. Delete is offered on every set and Cut on none, since a move takes its original out by variable name. A package whose sets are not laid out as MATLAB writes them offers neither tiles nor Delete.
The model engine (MODEL_FILE) offers its configuration sets the
editing core now takes:
- Add: EngineFile.addSections names the sections beside the variables
the gallery adds to ('config', where core says the model's sets take
a new one). TableView.addSections and the setRows field of the same
name carry them; the gallery shows those sections' tiles beside the
classes, each naming its section; MatView.addEntry adds into it.
- Delete: a set's row keeps core's Delete where the model's sets take
an edit; core refuses the active one, saying why. Cut is off
(_canCut: false, which the menu and its chord read): a move takes
its original out of this file by variable name.
- Rename and Description: core's row flags, as before.
The engine's observer now also asks the container a deleted node
left, so a set deleted (or an Add undone) repaints the table: a node
out of the tree has no parent to find its file by.
Its configuration sets are what a model's table now edits. The peer range stays ^1.56.0: with an older core the gallery offers no Configurations tile and a set no Delete, as before.
This was referenced Nov 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
.slxmodel's table now offers its configuration sets the editing a dictionary's get, on core v1.57.0 (mathworks/data-explorer-core#266):Add Config Set to Configurations).EngineFile.addSectionssays which sections beside the variables the gallery adds to (config, where core says the model's sets take a new one);TableView.addSectionsand the newsetRowsfield of the same name carry it;MatView.addEntryadds a tile's entry into its section._canCut: false, which the menu and its chord read): a move into another document takes its original out of this file by variable name.addSectionsis a new wire field rather than a member ofadd:check:apitreats any change to an existing wire field's type as breaking. The core peer range stays^1.56.0: with an older core the gallery offers no Configurations tile and a set no Delete, as before. The dev pin is v1.57.0.Tests
test/modelEngine/model.test.ts: tiles offered; a set and a reference added (one edit each, name editor opened, saved, undone); rename + Description; a name MATLAB refuses; delete and the active set refused; a package core cannot write offers neither.addGalleryGrid), wire (connectTableTasks), menu (menuItems).npm run verify: 4,720 tests pass.Downstream: vscode branch
model/config-set-edits(postsaddSectionsfrom its MAT-file editor).Known gap, pre-existing: a row drag of a configuration set defaults to a move, which cannot take the set out of the model (the paste lands, and the source says it could not remove the original).