Skip to content

run CI on pull requests #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oshchyhol merged 1 commit into from
Sep 29, 2026
Merged

run CI on pull requests #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@

name: Java CI with Maven

on: push
on:
push:
branches: [main]
pull_request:
Comment on lines +11 to +14

@oshchyhol oshchyhol Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[could] Fork PRs will now get a CI run, but main here has no required status checks, so a failing or not yet approved build (17) still won't block the merge. Release PR #73 went in with no checks at all. To match nodejs, python and ruby, a repo admin needs to mark build (17) as required on main, or the description could say that CI now runs on fork PRs but isn't enforced yet.

@oshchyhol oshchyhol Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgorDobryn @VladimirTaytor can you help with ^^that?


jobs:
build:
Expand Down
Loading