Skip to content

run CI on pull requests - #76

Merged
oshchyhol merged 1 commit into
mainfrom
ci-run-on-pull-requests
Sep 29, 2026
Merged

oshchyhol merged 1 commit into
mainfrom
ci-run-on-pull-requests

Conversation

@oshchyhol

@oshchyhol oshchyhol commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

CI only runs on push. When a PR comes from a fork, the contributor pushes to their fork, so CI runs there and never reports checks on the PR here. No checks are required on main, so a fork PR can be merged without any CI.

Changes

  • run the Java CI with Maven workflow on pull requests, and on push only for main (same as mailtrap-ruby)
  • pushes to a branch with no PR no longer run CI. Internal PRs still run CI once, not twice

How to test

  • on this PR, Java CI with Maven runs once and the build (17) check passes
  • after merge, Java CI with Maven runs on the push to main, and the Javadoc publish still runs as before
  • on the next fork PR, Java CI with Maven runs on the PR after a maintainer approves the first-time-contributor run

Images and GIFs

N/A

Summary by CodeRabbit

  • Chores
    • Automated checks now run for pull requests and for changes pushed to the main branch. They no longer run for pushes to every branch. These changes affect the project’s automated validation process and do not change app features or behavior.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d64781e6-e0e0-498e-9ea3-c8f4dd33c8a9

📥 Commits

Reviewing files that changed from the base of the PR and between 2bdf363 and b218fa2.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow now runs on pushes to main and on pull requests. Pushes to other branches no longer trigger the workflow.

Changes

CI workflow triggers

Layer / File(s) Summary
Configure workflow triggers
.github/workflows/ci.yml
The workflow triggers on pushes to main and on pull requests.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b218f

Pull requests now receive CI, while pushes trigger it only on main. The inspected workflow leaves no material merge-blocking risk.

Architecture Summary

Architecture risk: 🔵 Low · up to b218f

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/ci.yml: The trigger changes from pushes to any branch to pushes only to main, and adds pull requests as a trigger.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: running CI on pull requests. It is concise and specific.
Description check ✅ Passed The description includes the required Motivation, Changes, How to test, and Images and GIFs sections. It explains the fork PR issue, lists the workflow changes, and defines test checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oshchyhol
oshchyhol marked this pull request as ready for review September 28, 2026 11:55
Comment thread .github/workflows/ci.yml
Comment on lines +11 to +14
on:
push:
branches: [main]
pull_request:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[could] Fork PRs will now get a CI run, but main here has no required status checks, so a failing or not yet approved build (17) still won't block the merge. Release PR #73 went in with no checks at all. To match nodejs, python and ruby, a repo admin needs to mark build (17) as required on main, or the description could say that CI now runs on fork PRs but isn't enforced yet.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgorDobryn @VladimirTaytor can you help with ^^that?

@oshchyhol
oshchyhol merged commit 1848eb8 into main Sep 29, 2026
2 checks passed
@oshchyhol
oshchyhol deleted the ci-run-on-pull-requests branch September 29, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants