run CI on pull requests - #76
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CI workflow now runs on pushes to ChangesCI workflow triggers
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to Pull requests now receive CI, while pushes trigger it only on main. The inspected workflow leaves no material merge-blocking risk. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: |
There was a problem hiding this comment.
[could] Fork PRs will now get a CI run, but main here has no required status checks, so a failing or not yet approved build (17) still won't block the merge. Release PR #73 went in with no checks at all. To match nodejs, python and ruby, a repo admin needs to mark build (17) as required on main, or the description could say that CI now runs on fork PRs but isn't enforced yet.
There was a problem hiding this comment.
@IgorDobryn @VladimirTaytor can you help with ^^that?
Motivation
CI only runs on
push. When a PR comes from a fork, the contributor pushes to their fork, so CI runs there and never reports checks on the PR here. No checks are required onmain, so a fork PR can be merged without any CI.Changes
Java CI with Mavenworkflow on pull requests, and on push only formain(same as mailtrap-ruby)How to test
Java CI with Mavenruns once and thebuild (17)check passesJava CI with Mavenruns on the push tomain, and the Javadoc publish still runs as beforeJava CI with Mavenruns on the PR after a maintainer approves the first-time-contributor runImages and GIFs
N/A
Summary by CodeRabbit