Skip to content

Address feedback post- requiring RouteParams in Route #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentinewallace wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −6
Open

Address feedback post- requiring RouteParams in Route #4754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc4312a
Fuzz: remove unnecessary route_params clones
valentinewallace Jun 26, 2026
47f58f3
Set max fee in route params for probes
valentinewallace Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fuzz/src/chanmon_consistency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1866,7 +1866,7 @@ impl PaymentTracker {
}],
blinded_tail: None,
}],
route_params: route_params.clone(),
route_params,
};
let onion = RecipientOnionFields::secret_only(secret, amt);
let res = source.send_payment_with_route(route, hash, onion, id);
Expand Down Expand Up @@ -1946,7 +1946,7 @@ impl PaymentTracker {
],
blinded_tail: None,
}],
route_params: route_params.clone(),
route_params,
};
let onion = RecipientOnionFields::secret_only(secret, amt);
let res = source.send_payment_with_route(route, hash, onion, id);
Expand Down
5 changes: 1 addition & 4 deletions lightning/src/ln/outbound_payment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,17 +1922,14 @@ impl OutboundPayments {
}))
}

// `route_params` is a required field, but is unused when sending a probe along a fixed
// path. Construct dummy parameters from the path, leaving the fee budget unset to match
// the previous behavior of not tracking one for probes.
let route_params = {
let last_hop = path.hops.last().unwrap();
let payment_params =
PaymentParameters::from_node_id(last_hop.pubkey, last_hop.cltv_expiry_delta);
RouteParameters {
payment_params,
final_value_msat: path.final_value_msat(),
max_total_routing_fee_msat: None,
max_total_routing_fee_msat: Some(path.fee_msat()),
}
};
let route = Route { paths: vec![path], route_params };
Expand Down
Loading