Address feedback post- requiring RouteParams in Route#4754
Address feedback post- requiring RouteParams in Route#4754valentinewallace wants to merge 2 commits into
RouteParams in Route#4754Conversation
May as well, and allows removing a comment that explains why we were previously leaving it as None.
|
I've assigned @wpaulino as a reviewer! |
|
No issues found. The change correctly sets |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4754 +/- ##
==========================================
+ Coverage 84.56% 86.94% +2.37%
==========================================
Files 137 161 +24
Lines 77617 111650 +34033
Branches 77617 111650 +34033
==========================================
+ Hits 65636 97071 +31435
- Misses 9939 12072 +2133
- Partials 2042 2507 +465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Address feedback post-merge of #4693