Skip to content

Address feedback post- requiring RouteParams in Route#4754

Open
valentinewallace wants to merge 2 commits into
lightningdevkit:mainfrom
valentinewallace:2026-06-route-params-fixups
Open

Address feedback post- requiring RouteParams in Route#4754
valentinewallace wants to merge 2 commits into
lightningdevkit:mainfrom
valentinewallace:2026-06-route-params-fixups

Conversation

@valentinewallace

Copy link
Copy Markdown
Contributor

Address feedback post-merge of #4693

May as well, and allows removing a comment that explains why we were previously
leaving it as None.
@valentinewallace valentinewallace self-assigned this Jun 26, 2026
@valentinewallace valentinewallace added the weekly goal Someone wants to land this this week label Jun 26, 2026
@ldk-reviews-bot

ldk-reviews-bot commented Jun 26, 2026

Copy link
Copy Markdown

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-claude-review-bot

Copy link
Copy Markdown
Collaborator

No issues found.

The change correctly sets max_total_routing_fee_msat to Some(path.fee_msat()) for probes — fee_msat() returns only routing fees (excluding the final hop value), matching the intent. The fuzz changes safely remove .clone() since route_params is moved into the Route and not used afterward.

@ldk-reviews-bot ldk-reviews-bot requested a review from wpaulino June 26, 2026 15:03
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.94%. Comparing base (7962098) to head (47f58f3).
⚠️ Report is 3228 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4754      +/-   ##
==========================================
+ Coverage   84.56%   86.94%   +2.37%     
==========================================
  Files         137      161      +24     
  Lines       77617   111650   +34033     
  Branches    77617   111650   +34033     
==========================================
+ Hits        65636    97071   +31435     
- Misses       9939    12072    +2133     
- Partials     2042     2507     +465     
Flag Coverage Δ
fuzzing-fake-hashes 8.43% <0.00%> (?)
fuzzing-real-hashes 32.42% <0.00%> (?)
tests 86.27% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

weekly goal Someone wants to land this this week

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants