fix(gui): carry scoped Combo quota editing (#4105) - #4339
Merged
Conversation
Contributor
|
✅ Deterministic PR hygiene checks passed. |
lidge-jun
force-pushed
the
codex/260912-60plus-combo-editor
branch
from
September 12, 2026 04:42
e49d63e to
4476e7d
Compare
Contributor
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (37)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
Contributor
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
lidge-jun
force-pushed
the
codex/260912-60plus-combo
branch
from
September 12, 2026 04:57
34a3ce7 to
0bcb43e
Compare
lidge-jun
force-pushed
the
codex/260912-60plus-combo-editor
branch
from
September 12, 2026 04:58
c2cc8d6 to
e7a68d2
Compare
lidge-jun
marked this pull request as ready for review
September 12, 2026 05:01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carry the editor feature from #4105 above runtime carry #4336. Combo Save/Create blocks only when every usable target has fresh server-confirmed inference exhaustion. Missing, malformed, expired or display-only evidence remains unknown and permits editing. Deadline timers, activation, visibility and Refresh re-evaluate quota without dropping drafts.
The supporting management
routingQuotaprojection exposes state/timestamps only and preserves private credential bindings. The original stale prerequisite is omitted; #4336 includes the newer explicit-projection correction.Ordinary manual chain (merge bottom-up by parent coordinator): #4336 runtime -> this editor PR. This PR targets codex/260912-60plus-combo. Originals #4090 and #4105 remain open pending integration.
Source commits: af2ceb8 and 50296f1.
Co-authored-by: luvs01 27862058+luvs01@users.noreply.github.com
Verification
Checklist
GUI evidence
Actual Vite-rendered worktree with synthetic API fixtures; source b3175ae. Current full GUI tree differs due upstream provider-catalog changes; independent rebase audit confirms unchanged Combo components/parser/resource logic/Models shell/styles/icons/existing translations and identical PNGs. These are historical captures of the unchanged Combo surface, not a fresh rendering of the rebased tip. No local build/install/test suite. Dirty public model name is the same in both captures.
Fresh inference exhaustion: Save disabled.
Unknown evidence with exhausted display quota: Save enabled.
Expired evidence also permits editing; capture and provenance in devlog/_plan/260912_combo_carry/034_render_evidence.md.
Rebased onto dev5042a376ef with documentation-only conflict resolution; current head e7a68d2. Product carry delta retained; final cumulative CI restarted.
Maintainer integration decision
Owner-authorized ordinary manual-chain integration, lower #4336 then editor #4339. Current reviewed layer head:
e7a68d208e579a08145e79397309e146a314db0c; cumulative final tip:e7a68d208e579a08145e79397309e146a314db0c. Independent runtime security review Averroes PASS; editor security review Bacon PASS after mixed-snapshot clock correction and deterministic fixture settling. Bacon reviewed the rebase/cascade delta: thirteen structure append conflicts preserve both upstream and quota content; product/test carry patches unchanged. Coordinator inspected routing scope/binding source, merge topology, current review threads and synthetic GUI evidence. Original luvs01 attribution remains.The owner explicitly forbids every local suite and requests trailing CI at the final cumulative tip only. PR CI https://github.com/lidge-jun/opencodex/actions/runs/34674364710 and all-lane dispatch https://github.com/lidge-jun/opencodex/actions/runs/34674363301 are pending. Intermediate-tip test success is not asserted. Windows all-lane runner type follows the existing workflow; no workflow, protection or cancellation changes were made. Captured Combo-source behavior is linked by unchanged relevant source/assets, not misrepresented as a new full-tree render. Local suites/build/typecheck/install NOT RUN. Trailing failures remain repair obligations.