Skip to content

fix(combos): carry scoped inference quota evidence (#4090) - #4336

Merged
lidge-jun merged 4 commits into
devfrom
codex/260912-60plus-combo
Sep 12, 2026
Merged

fix(combos): carry scoped inference quota evidence (#4090)#4336
lidge-jun merged 4 commits into
devfrom
codex/260912-60plus-combo

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

Carry #4090 onto the current TypeScript runtime. Provider-wide Combo exclusion, reset-window ordering and catalog inactivity now use explicit inference projections bound to the current single credential. Display-only account/model/search/MCP reports do not veto a provider. The latest omitted-projection correction and its direct regression are retained.

Current-dev adaptation migrates the newer catalog inactivity consumer, aligns the exclusive freshness deadline, adds binding-change regressions, and moves the original contract into the current structure docs.

Ordinary manual chain: this runtime layer targets dev; editor layer #4339 targets this head. Parent coordinator owns merge. Original #4090 remains open pending integration.

Source: a110c49, a9694ff, c061316.

Co-authored-by: luvs01 27862058+luvs01@users.noreply.github.com

Verification

  • Local tests, typecheck, build and install: NOT RUN by explicit maintainer instruction. No focused suite was run.
  • git diff --check 6a844ef HEAD: exit 0 (text inspection only).
  • Independent design reflection and runtime plan audit passed. Averroes explicitly reviewed all 20 runtime-diff files and the fixture-only follow-up: security PASS, zero blockers at 34a3ce7. This is agent review, not maintainer approval.
  • Hosted CI will be tracked at the final cumulative editor tip as requested. Intermediate-tip test success is not claimed.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Rebased onto dev5042a376ef with documentation-only conflict resolution; current head 0bcb43e. Product carry delta retained; final cumulative CI restarted.

Maintainer integration decision

Owner-authorized ordinary manual-chain integration, lower #4336 then editor #4339. Current reviewed layer head: 0bcb43e266f500bee3acdaa5dde8eff41f34df00; cumulative final tip: e7a68d208e579a08145e79397309e146a314db0c. Independent runtime security review Averroes PASS; editor security review Bacon PASS after mixed-snapshot clock correction and deterministic fixture settling. Bacon reviewed the rebase/cascade delta: thirteen structure append conflicts preserve both upstream and quota content; product/test carry patches unchanged. Coordinator inspected routing scope/binding source, merge topology, current review threads and synthetic GUI evidence. Original luvs01 attribution remains.

The owner explicitly forbids every local suite and requests trailing CI at the final cumulative tip only. PR CI https://github.com/lidge-jun/opencodex/actions/runs/34674364710 and all-lane dispatch https://github.com/lidge-jun/opencodex/actions/runs/34674363301 are pending. Intermediate-tip test success is not asserted. Windows all-lane runner type follows the existing workflow; no workflow, protection or cancellation changes were made. Captured Combo-source behavior is linked by unchanged relevant source/assets, not misrepresented as a new full-tree render. Local suites/build/typecheck/install NOT RUN. Trailing failures remain repair obligations.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 12, 2026
lidge-jun and others added 4 commits September 12, 2026 13:56
@lidge-jun
lidge-jun force-pushed the codex/260912-60plus-combo branch from 34a3ce7 to 0bcb43e Compare September 12, 2026 04:57
@lidge-jun
lidge-jun marked this pull request as ready for review September 12, 2026 05:00
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 12, 2026 05:00
@lidge-jun
lidge-jun merged commit eb3761b into dev Sep 12, 2026
5 of 8 checks passed
@lidge-jun
lidge-jun deleted the codex/260912-60plus-combo branch September 12, 2026 05:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T05:02:26.256926Z 0bcb43e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant