Repository navigation
Conversation
ctawiah
added this pull request to stack #844
October 2, 2026 20:40
This was referenced Oct 2, 2026
ctawiah
force-pushed
the
ctawiah/sync-attachment-reconciliation
branch
from
October 2, 2026 20:43
f6859f6 to
2adc8c0
Compare
This was referenced Oct 2, 2026
ctawiah
marked this pull request as ready for review
October 7, 2026 14:56
ld-ahartmann
approved these changes
Oct 7, 2026
ctawiah
force-pushed
the
ctawiah/sync-attachment-reconciliation
branch
from
October 7, 2026 15:41
2adc8c0 to
8a9a250
Compare
ctawiah
force-pushed
the
ctawiah/sync-attachment-reconciliation
branch
from
October 7, 2026 15:44
8a9a250 to
0cde3fe
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0cde3fe. Configure here.
| if strings.HasSuffix(path, variationFileSuffix) { | ||
| return false, fmt.Errorf("%w: %s", ErrVariationExists, path) | ||
| } | ||
| return false, nil |
There was a problem hiding this comment.
Add fingerprints skipped attachment files
Medium Severity
finishSelection fingerprints a new variation from hydrated server attachment content, then createResourceFile leaves any existing tool or skill file untouched. The stored baseline can describe content that is not on disk, so the wrapper looks dirty on the next sync.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0cde3fe. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Context
This layer connects tool and skill attachments to the prompt sync lifecycle. A synchronized variation can now reference local tool and skill files, compare them with LaunchDarkly, and update both sides without treating version numbers as content changes.
What changes
A synchronized workspace now uses this layout:
Review focus
Verification
go test ./internal/sync/...go test ./cmd/syncgo test ./...git diff --checkRelated changes
Review the stack in this order:
Note
Overview
Adds tool and skill attachments to prompt sync so variations can reference shared
tools/*.jsonandskills/*.mdfiles under.launchdarkly/<project>/, compile them into the variation payload, and round-triptools/skillson create/update variation API calls.Local workspace & bootstrap: Bootstrap hydrates attachment content and version pins from the API before writing files; creation writes variation wrappers and dependency files together, records tool/skill baselines in the manifest, and rolls back only newly created paths if manifest persistence fails. Compile/load resolves attachment refs from disk (with symlink rejection on managed paths).
Fingerprints & manifest: Variation fingerprints include canonical attachment content while ignoring runtime version pins; separate attachment fingerprints track shared tools/skills once. Detach and post-sync pruning drop manifest entries for attachments no longer referenced by any remaining variation.
Sync planning & execution: Plans hydrate server attachments, diff tools/skills separately, detect stale version pins, and group conflicts when multiple variations share a changed dependency. Execution versions or creates tools (with optional local
upsert) before patching variations, blocks the whole plan while any conflict remains unresolved, and refreshes server pins when pulling LaunchDarkly locally.Reviewed by Cursor Bugbot for commit 0cde3fe. Bugbot is set up for automated code reviews on this repo. Configure here.