Repository navigation
Conversation
ctawiah
added this pull request to stack #844
October 2, 2026 20:40
This was referenced Oct 2, 2026
ctawiah
marked this pull request as ready for review
October 2, 2026 21:02
This was referenced Oct 6, 2026
ld-ahartmann
approved these changes
Oct 7, 2026
ld-ahartmann
left a comment
There was a problem hiding this comment.
not diving too deep but all looks reasonable here
ctawiah
force-pushed
the
ctawiah/sync-attachment-foundation
branch
from
October 7, 2026 15:41
fc0160e to
171d01b
Compare
ctawiah
force-pushed
the
ctawiah/sync-attachment-foundation
branch
from
October 7, 2026 15:44
171d01b to
d49b3db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This stack adds support for attaching LaunchDarkly tools and skills to prompt variations that are synchronized with repository files. This first layer adds the API and interactive search behavior the rest of the stack builds on. It does not write attachment files or change how variations are reconciled yet.
What changes
Review focus
Verification
go test ./internal/sync/api ./internal/sync/interactive ./internal/sync/bootstrap ./internal/sync/link ./internal/sync/promptgo test ./...git diff --checkRelated changes
Review the stack in this order:
Note
Overview
Adds the sync API and UX foundation for versioned AI tools and skills, and shifts catalog picking from “load everything” to server-filtered, paginated search.
The unified
Clientnow exposesSearchProjects,SearchConfigs, and newSearchAttachments/ReadAttachment/CreateAttachment/UpdateAttachmentagainstai-toolsandai-configs/skills, with tool search results re-fetched so the UI always shows the latest version. Domain typesTool,Skill, andAttachmentland inresource.gofor later reconciliation layers.Bootstrap and link flows use a shared
SearchSelectTUI (/to search, load more, alt-screen forms) instead of preloading full project/config lists; config search can pass mode filters (e.g. link respects prompt mode).IsNotFoundand shared mutation/status helpers support attachment error handling in follow-up PRs.Reviewed by Cursor Bugbot for commit d49b3db. Bugbot is set up for automated code reviews on this repo. Configure here.